Skip to content

fix: add tests and implement graphql over http cases#806

Merged
jensneuse merged 5 commits intomainfrom
fix/properly-implement-graphql-over-http
May 20, 2024
Merged

fix: add tests and implement graphql over http cases#806
jensneuse merged 5 commits intomainfrom
fix/properly-implement-graphql-over-http

Conversation

@jensneuse
Copy link
Copy Markdown
Member

This PR Fixes a few issues with malformed requests, ensuring that we properly implement GraphQL over HTTP.
Valid JSON but invalid variables is a 200 with errors.
Invalid request with invalid GraphQL Operation is 400 with errors.

@jensneuse jensneuse requested a review from StarpTech May 20, 2024 13:24
Comment thread router-tests/graphql_over_http_test.go Outdated
Comment thread router-tests/graphql_over_http_test.go Outdated
Comment thread router/core/operation_processor.go
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensneuse jensneuse merged commit 6d73074 into main May 20, 2024
@jensneuse jensneuse deleted the fix/properly-implement-graphql-over-http branch May 20, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants