feat: add hashHeadersWhitelist configuration for selective header hashing#803
Closed
glower wants to merge 1 commit intowundergraph:mainfrom
glower:feature/ws-header-whitelist
Closed
feat: add hashHeadersWhitelist configuration for selective header hashing#803glower wants to merge 1 commit intowundergraph:mainfrom glower:feature/ws-header-whitelist
glower wants to merge 1 commit intowundergraph:mainfrom
glower:feature/ws-header-whitelist
Conversation
… header hashing Added support for a new configuration option `hashHeadersWhitelist` in the WebSocket configuration. This allows specifying a whitelist of headers that should be hashed and forwarded during WebSocket connections. The implementation includes updates to the schema and handling of the new configuration option in the `WebSocketConnectionHandler`.\n\nEnsured that the existing `ignoreHeader` method remains intact for backward compatibility. Users can use `hashHeadersWhitelist` to specify headers to be hashed in addition to those already managed by `ignoreHeader`.
glower
commented
May 18, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for a new configuration option
hashHeadersWhitelistin the WebSocket configuration. This allows specifying a whitelist of headers that should be hashed and forwarded during WebSocket connections.The implementation includes updates to the schema and handling of the new configuration option in the
WebSocketConnectionHandlerMotivation and Context
Implement an allow-list to have fine-grained control over which headers are hashed in the initial subscription upgrade request.
TODO