Skip to content

chore(docs): create cosmo-cloud-terms.md#6

Closed
wunderhawk wants to merge 3 commits intomainfrom
bjoern/cosmo-terms
Closed

chore(docs): create cosmo-cloud-terms.md#6
wunderhawk wants to merge 3 commits intomainfrom
bjoern/cosmo-terms

Conversation

@wunderhawk
Copy link
Copy Markdown
Contributor

Dustin suggested placing the file here - feel free to move it (pls document in Linear!)

@wunderhawk wunderhawk closed this Aug 24, 2023
@wunderhawk wunderhawk deleted the bjoern/cosmo-terms branch August 24, 2023 13:47
jensneuse added a commit that referenced this pull request Mar 7, 2026
Data race in graphql-go-tools/v2 resolve.go between
trigger.subscriptionIds() read and handleAddSubscription write.
Cannot fix in this repo (upstream dependency). Move to TestFlaky
so CI retries these with test_retry_count=3.

Also add guideline #6 to CLAUDE.md: wait for ALL periodic exporter
items, not just one sentinel value.

chore: CI stability run 1/50 (reset after fix)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jensneuse added a commit that referenced this pull request Apr 19, 2026
See TODO.md for the per-item resolution log.

Highlights:
- Namespace 6 new entity-caching directives as @openfed__ (Aenimus).
- Proto field rename negative_cache_ttl_seconds -> not_found_cache_ttl_seconds
  (field #6 preserved, old name reserved) + TTL-semantics field comments.
- Composition correctness: nested-key mapping iterates all + carries
  correct isBatch on list returns; renamed root types attach cache config
  under the canonical root; TypeScript hygiene (branded aliases, Array<T>,
  ordinal helper, alphabetical constants, reuse isTypeNodeListType).
- Router: default cache stored under both "default" and its provider_id so
  overrides reuse the instance; executor nil-safety + skip+warn on unknown
  subgraph ID; buildRedisClient rename; logEntityCacheOverrideIssues
  rename; metrics source labels via CacheOperationSource; otel attribute
  constants; config.schema.json memory max_size bytes-string format.
- Test truthfulness: 10 router-tests subtests now assert counters.* and/or
  cache.Len(); 9 of 10 fail with L2 disabled (was 0). negative_cache tests
  redesigned with mutation-created IDs; items subgraph mutations persist
  and emit events. Circuit breaker concurrent tests; redis post-close Set
  and Delete coverage; memory concurrency test error propagation;
  ristretto bounded assertion; post-close len guard.
- New unit coverage: entity_cache_metrics_test.go (0% -> ~94%),
  graphql_handler caching-options tests, router_entity_cache_test.go
  covering default-cache reuse via require.Same.
- Playground: functional setHeaders (no stale closure), Math.max zero
  duration clamp, controlled Tabs.
- Docs: PII redaction on raw keys, namespace sweep across all references,
  ENTITY_CACHING_DEMO SDL refresh, CLAUDE.md cheatsheet + code-block tags.

Flagged follow-up: @openfed__cachePopulate writes still land in L2 when
L2.Enabled=false. Read path correctly gates so user-visible impact is
wasted writes only. Fix location: cache-populate write path must respect
EntityCachingConfiguration.L2.Enabled.

Verified:
- composition: 1194 tests pass.
- router, router-tests: -race clean.
- router-tests/entity_caching: 63/64 pass (1 pre-existing skip).
- cache-demo e2e: every documented query + all three
  X-WG-Disable-Entity-Cache* header gates behave as documented.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jensneuse added a commit that referenced this pull request Apr 24, 2026
)

- #3: shrink oversized multi-line comment on L1/request-scoped nested dedup
  to three lines that explain the invariant instead of reading like scratch
  debugging notes
- #4: verified the L1 test has a meaningful assertion — counters.viewer == 1
  with L1 on, == 3 with L1 off (inverse baseline exists); keep the test
- #6: audit layer-named tests; L2/... subtests that used the combined
  entityCachingOptionsWithCircuitBreakerRef and entityCachingOptionsWithSubgraphConfig
  helpers are now L2-only. The one intentional hybrid is renamed
  L1/deduplicates with warm L2 → Combined/L1 deduplicates with warm L2

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
comatory added a commit that referenced this pull request Apr 29, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant