fix: accept empty lists for non-null list items - #3098
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request updates ChangesGraphQL tools validation fix
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
❌ Internal Query Planner CI checks failedThe Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
==========================================
- Coverage 71.13% 61.83% -9.31%
==========================================
Files 335 262 -73
Lines 49342 30810 -18532
Branches 6042 0 -6042
==========================================
- Hits 35101 19050 -16051
+ Misses 14215 10232 -3983
- Partials 26 1528 +1502 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@router-tests/operations/variables_validation_test.go`:
- Around line 19-24: Update the “empty list default for non-null list items”
subtest to omit the Variables field so the query uses its declared [] default,
and change the expected response to rootFieldWithListArg returning an empty
list. If retaining coverage for ["a"], move it into a separate subtest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 60caf48a-ceb5-4f35-827d-d277df6e0c30
📒 Files selected for processing (1)
router-tests/operations/variables_validation_test.go
fixes #3095
Summary by CodeRabbit
Summary by CodeRabbit
Chores
Tests
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.