Skip to content

fix: metrics flush timeout canceled shutdown - #2990

Merged
Noroth merged 16 commits into
mainfrom
ludwig/otel-fixes
Jul 1, 2026
Merged

Noroth merged 16 commits into
mainfrom
ludwig/otel-fixes

chore: use compare and swap

cd8aa46
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 1, 2026 in 1s

61.39% (target 30.00%)

View this Pull Request on Codecov

61.39% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 56.92308% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.39%. Comparing base (db31b60) to head (cd8aa46).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
router/core/graph_server.go 64.70% 6 Missing and 6 partials ⚠️
router/internal/exporter/exporter.go 72.22% 4 Missing and 1 partial ⚠️
router/core/graphql_prehandler.go 0.00% 2 Missing ⚠️
router/pkg/metric/metric_store.go 33.33% 0 Missing and 2 partials ⚠️
router/pkg/metric/cache_metrics.go 0.00% 1 Missing ⚠️
router/pkg/metric/engine_metrics.go 0.00% 1 Missing ⚠️
router/pkg/metric/oltp_connection_metric_store.go 0.00% 1 Missing ⚠️
router/pkg/metric/otlp_metric_store.go 0.00% 1 Missing ⚠️
router/pkg/metric/prom_connection_metric_store.go 0.00% 1 Missing ⚠️
router/pkg/metric/prom_metric_store.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   65.49%   61.39%   -4.10%     
==========================================
  Files         335      259      -76     
  Lines       48737    30053   -18684     
  Branches     5424        0    -5424     
==========================================
- Hits        31918    18451   -13467     
+ Misses      16793    10116    -6677     
- Partials       26     1486    +1460     
Files with missing lines Coverage Δ
router/pkg/metric/connection_metric_store.go 56.75% <100.00%> (ø)
router/pkg/metric/oltp_stream_metric_store.go 88.88% <ø> (ø)
router/pkg/metric/stream_metric_store.go 82.60% <ø> (ø)
router/pkg/metric/cache_metrics.go 85.84% <0.00%> (ø)
router/pkg/metric/engine_metrics.go 75.90% <0.00%> (ø)
router/pkg/metric/oltp_connection_metric_store.go 83.33% <0.00%> (ø)
router/pkg/metric/otlp_metric_store.go 81.25% <0.00%> (ø)
router/pkg/metric/prom_connection_metric_store.go 83.33% <0.00%> (ø)
router/pkg/metric/prom_metric_store.go 87.96% <0.00%> (ø)
router/pkg/metric/router_runtime_metrics.go 76.38% <0.00%> (ø)
... and 4 more

... and 580 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.