feat: enable to ignore cost weights on implementing types - #2976
Conversation
This PR adds a feature flag that allows to emulate behavior of Apollo which ignores weights on implementing types when the field on interface does not have cost weight assigned.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new ChangesIgnoreImplementingTypeWeights Cost Control Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
===========================================
+ Coverage 41.75% 66.45% +24.70%
===========================================
Files 142 258 +116
Lines 13755 27558 +13803
Branches 711 0 -711
===========================================
+ Hits 5743 18314 +12571
+ Misses 8010 7788 -222
- Partials 2 1456 +1454
🚀 New features to boost your workflow:
|
…across-implementations-instead
…across-implementations-instead
This PR adds a feature flag that allows to emulate behavior
of Apollo that ignored weights on implementing types when
the fields on interface does not have cost weight assigned.
It includes the following fixes:
Fixes ENG-9717
Fixes ENG-9779
Summary by CodeRabbit
Summary by CodeRabbit
security.cost_control.ignore_implementing_type_weights(default:false) to ignore@costweights from implementing types on interface/union fields when the abstract type has no defined weight.