Skip to content

chore: add pool queue size and thread count as Sentry measurements - #2940

Merged
gausie merged 5 commits into
mainfrom
composition-pool-queue-metrics
Jun 10, 2026
Merged

chore: add pool queue size and thread count as Sentry measurements#2940
gausie merged 5 commits into
mainfrom
composition-pool-queue-metrics

Conversation

@gausie

@gausie gausie commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Captures pool.queueSize and pool.threads as both span attributes and Sentry measurements on ComposeGraphsPool.composeGraphsInWorker spans.

  • Span attributes — visible in the trace explorer on the individual span
  • Sentry measurements — numeric, aggregatable at the transaction level for use in dashboards (avg, max, p95 etc.)

This supports building a Sentry dashboard for composition queue usage, split by hostname/pod.

Summary by CodeRabbit

  • Chores
    • Updated development configuration files
    • Enhanced monitoring capabilities for worker pool performance tracking

@gausie
gausie requested review from a team as code owners June 9, 2026 12:54
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 74afd9a6-3cd3-48bd-80d0-1a38ea696f83

📥 Commits

Reviewing files that changed from the base of the PR and between 35a0ad6 and 5465c26.

📒 Files selected for processing (2)
  • .gitignore
  • controlplane/src/core/composition/composeGraphs.pool.ts

Walkthrough

The PR adds Claude Code working directory patterns to .gitignore and extends Sentry observability instrumentation for the compose graphs worker pool by recording thread count metrics alongside existing queue size measurements.

Changes

Dev environment and observability updates

Layer / File(s) Summary
Dev environment ignore patterns
.gitignore
Claude Code working directory path .claude/worktrees/ added to the ignore configuration to keep IDE-specific artifacts out of version control.
Worker pool thread metrics
controlplane/src/core/composition/composeGraphs.pool.ts
Compose graphs worker pool instrumentation extended to record pool.threads as a span attribute and Sentry measurement, providing visibility into active worker thread count alongside existing queue size metrics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • wundergraph/cosmo#2931: Both PRs extend Sentry span instrumentation for the composition worker pool, with the related PR adding queueSize and this PR adding threads metrics.
  • wundergraph/cosmo#2905: Both PRs modify composeGraphs.pool.ts to enhance Sentry tracing around the compose graphs worker pool.
  • wundergraph/cosmo#2901: Both PRs add or extend Sentry instrumentation on the worker pool execution path in composeGraphs.pool.ts.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding pool queue size and thread count as Sentry measurements, which matches the implementation in the composition pool instrumentation file.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (7961cf4) to head (065db28).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2940      +/-   ##
==========================================
- Coverage   66.31%   65.13%   -1.18%     
==========================================
  Files         258      327      +69     
  Lines       27357    47138   +19781     
  Branches        0     5241    +5241     
==========================================
+ Hits        18141    30703   +12562     
- Misses       7775    16411    +8636     
+ Partials     1441       24    -1417     
Files with missing lines Coverage Δ
...olplane/src/core/composition/composeGraphs.pool.ts 88.05% <100.00%> (ø)

... and 584 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gausie
gausie enabled auto-merge (squash) June 10, 2026 13:43
@gausie
gausie merged commit b9405fa into main Jun 10, 2026
10 checks passed
@gausie
gausie deleted the composition-pool-queue-metrics branch June 10, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants