chore: add hostname tag to Sentry config - #2934
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR imports Node's ChangesSentry Hostname Tag
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@controlplane/src/core/sentry.config.ts`:
- Line 37: The Sentry hostname tag is only set in Sentry.init path in
Sentry.setTag('hostname', os.hostname()) within sentry.config.ts but the worker
Sentry initialization in the composeGraphs.worker (function/initializer that
configures Sentry in controlplane/src/core/composition/composeGraphs.worker.ts)
does not set this tag, so add the same call to set the hostname tag after the
worker Sentry initialization (i.e., call Sentry.setTag('hostname',
os.hostname()) or equivalent using the worker's Sentry instance immediately
after its Sentry.init/configure step) so events from the worker include the
hostname tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0fd81586-103d-4538-b793-42bcf7bede9e
📒 Files selected for processing (1)
controlplane/src/core/sentry.config.ts
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
- Coverage 65.13% 65.12% -0.01%
==========================================
Files 327 327
Lines 47127 47130 +3
Branches 5239 5239
==========================================
- Hits 30697 30695 -2
- Misses 16406 16411 +5
Partials 24 24
🚀 New features to boost your workflow:
|
Tags each Sentry event with the hostname of the machine generating the telemetry, making it easier to filter and correlate events by server instance.
Summary by CodeRabbit