Skip to content

test(router): update MCP input-schema goldens to union nullable form - #2926

Merged
ysmolski merged 1 commit into
yury/eng-9581-inline-fragments-on-abstract-list-types-charge-all-itemsfrom
ahmet/fix-mcp-golden-nullable-union
Jun 8, 2026
Merged

test(router): update MCP input-schema goldens to union nullable form#2926
ysmolski merged 1 commit into
yury/eng-9581-inline-fragments-on-abstract-list-types-charge-all-itemsfrom
ahmet/fix-mcp-golden-nullable-union

Conversation

@asoorm

@asoorm asoorm commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Updates two stale goldens in router-tests/protocol/mcp_test.go to unblock the ./protocol job on #2925.

The engine bump (graphql-go-tools #1518/#1528) changed nullable rendering from {"type":"x","nullable":true} to the union {"type":["x","null"]} (nullable enums gain a trailing null). These goldens hard-code the generated schema, so they went stale. Engine fix is correct; goldens just needed updating.

@asoorm
asoorm requested a review from a team as a code owner June 8, 2026 11:05

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2a9577e9-8431-4699-a9a8-eea1daf99647

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-32381a5d1c4e6bea8291d3de32816c57dd9d58a4

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.27%. Comparing base (a58f2c8) to head (a113811).

Additional details and impacted files
@@                                            Coverage Diff                                             @@
##           yury/eng-9581-inline-fragments-on-abstract-list-types-charge-all-items    #2926      +/-   ##
==========================================================================================================
+ Coverage                                                                   63.18%   66.27%   +3.09%     
==========================================================================================================
  Files                                                                         258      258              
  Lines                                                                       27309    27309              
==========================================================================================================
+ Hits                                                                        17254    18100     +846     
+ Misses                                                                       8653     7773     -880     
- Partials                                                                     1402     1436      +34     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asoorm asoorm changed the title Fix MCP input-schema goldens for union nullable form (#2925) test(router): update MCP input-schema goldens to union nullable form Jun 8, 2026
@ysmolski
ysmolski merged commit a4b8b6c into yury/eng-9581-inline-fragments-on-abstract-list-types-charge-all-items Jun 8, 2026
25 of 26 checks passed
@ysmolski
ysmolski deleted the ahmet/fix-mcp-golden-nullable-union branch June 8, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants