test(router): update MCP input-schema goldens to union nullable form - #2926
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## yury/eng-9581-inline-fragments-on-abstract-list-types-charge-all-items #2926 +/- ##
==========================================================================================================
+ Coverage 63.18% 66.27% +3.09%
==========================================================================================================
Files 258 258
Lines 27309 27309
==========================================================================================================
+ Hits 17254 18100 +846
+ Misses 8653 7773 -880
- Partials 1402 1436 +34 🚀 New features to boost your workflow:
|
a4b8b6c
into
yury/eng-9581-inline-fragments-on-abstract-list-types-charge-all-items
Updates two stale goldens in
router-tests/protocol/mcp_test.goto unblock the./protocoljob on #2925.The engine bump (graphql-go-tools #1518/#1528) changed nullable rendering from
{"type":"x","nullable":true}to the union{"type":["x","null"]}(nullable enums gain a trailingnull). These goldens hard-code the generated schema, so they went stale. Engine fix is correct; goldens just needed updating.