fix: use float64 for intermediate cost calculations - #2887
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThis PR updates the ChangesDependency Update and Cost Test Adjustments
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2887 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 258 258
Lines 27056 27056
=======================================
Hits 17923 17923
+ Misses 7720 7719 -1
- Partials 1413 1414 +1 🚀 New features to boost your workflow:
|
Previously we were rounding cost at every level of cost calculation.
That lead to accumulated drift, especially on the deeply nested
queries.
Round the cost on the return (final node) instead of intermediate nodes.
Summary by CodeRabbit
Chores
Tests