Skip to content

feat: split router config - #2834

Merged
Aenimus merged 11 commits into
feat/split-configsfrom
wilson/eng-9429-controlplane-support-detached-router-execution-configs
May 8, 2026
Merged

feat: split router config#2834
Aenimus merged 11 commits into
feat/split-configsfrom
wilson/eng-9429-controlplane-support-detached-router-execution-configs

Conversation

@wilsonrivera

@wilsonrivera wilsonrivera commented May 7, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai summary

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 98ca467b-6aac-4e26-b471-302a0b703322

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.73329% with 177 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/split-configs@c4bd8ba). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ntrolplane/src/core/services/CompositionService.ts 90.60% 79 Missing ⚠️
...rvices/graph/setGraphRouterCompatibilityVersion.ts 19.23% 19 Missing and 2 partials ⚠️
.../src/core/repositories/FederatedGraphRepository.ts 88.14% 16 Missing ⚠️
...e/bufservices/federated-graph/migrateFromApollo.ts 0.00% 11 Missing ⚠️
.../src/core/bufservices/monograph/updateMonograph.ts 8.33% 11 Missing ⚠️
controlplane/src/core/composition/composer.ts 56.52% 10 Missing ⚠️
...lplane/src/core/repositories/SubgraphRepository.ts 87.65% 10 Missing ⚠️
...core/bufservices/feature-flag/createFeatureFlag.ts 82.75% 5 Missing ⚠️
...core/bufservices/feature-flag/updateFeatureFlag.ts 83.33% 5 Missing ⚠️
...ne/src/core/bufservices/contract/createContract.ts 95.23% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/split-configs    #2834   +/-   ##
=====================================================
  Coverage                      ?   64.16%           
=====================================================
  Files                         ?      312           
  Lines                         ?    44701           
  Branches                      ?     4816           
=====================================================
  Hits                          ?    28684           
  Misses                        ?    15992           
  Partials                      ?       25           
Files with missing lines Coverage Δ
...plane/src/core/bufservices/graph/recomposeGraph.ts 79.39% <100.00%> (ø)
...src/core/bufservices/monograph/publishMonograph.ts 64.00% <100.00%> (ø)
...lane/src/core/bufservices/subgraph/moveSubgraph.ts 84.70% <100.00%> (ø)
...ne/src/core/bufservices/subgraph/updateSubgraph.ts 83.88% <100.00%> (ø)
...ane/src/core/repositories/FeatureFlagRepository.ts 86.83% <100.00%> (ø)
controlplane/src/db/schema.ts 100.00% <100.00%> (ø)
controlplane/src/types/index.ts 100.00% <100.00%> (ø)
...ne/src/core/bufservices/contract/createContract.ts 77.45% <95.23%> (ø)
...ne/src/core/bufservices/contract/updateContract.ts 77.14% <97.61%> (ø)
...core/bufservices/feature-flag/deleteFeatureFlag.ts 87.25% <96.66%> (ø)
... and 15 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread controlplane/src/core/services/CompositionService.ts Outdated
Comment thread controlplane/src/core/services/CompositionService.ts Outdated
Comment thread controlplane/src/core/bufservices/monograph/updateMonograph.ts Outdated
Comment thread controlplane/test/feature-flag/feature-flag-integration-v2.test.ts Outdated
Comment thread controlplane/test/feature-flag/feature-flag-integration-v2.test.ts
Comment thread controlplane/test/feature-flag/feature-flag-integration-v2.test.ts
@wilsonrivera
wilsonrivera marked this pull request as ready for review May 8, 2026 14:24

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@Aenimus
Aenimus merged commit e673a39 into feat/split-configs May 8, 2026
6 checks passed
@Aenimus
Aenimus deleted the wilson/eng-9429-controlplane-support-detached-router-execution-configs branch May 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants