Skip to content

fix: drop NodeJS 20 support#2805

Merged
comatory merged 4 commits intomainfrom
ondrej/eng-9463-cosmomonorepo-drop-nodejs-v20-support
Apr 29, 2026
Merged

fix: drop NodeJS 20 support#2805
comatory merged 4 commits intomainfrom
ondrej/eng-9463-cosmomonorepo-drop-nodejs-v20-support

Conversation

@comatory
Copy link
Copy Markdown
Contributor

@comatory comatory commented Apr 29, 2026

Drops support for NodeJS 20 as it no longer will be LTS release. Additionally adds prettier as a runtime dependency to studio and adjusts imports.

Summary by CodeRabbit

  • Chores

    • Pinned Node.js to 22.x in build actions.
    • Added Prettier to project dependencies.
  • Style

    • Adjusted formatter plugin import to ensure consistent formatting.
  • Tests

    • CI test matrix updated to run against Node.js 22.x and 24.x.
  • Documentation

    • CLI prerequisite updated to require Node.js 22+ (>=22.11.0).

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8bf2bc86-e838-41ce-8e55-ce2885c3084a

📥 Commits

Reviewing files that changed from the base of the PR and between da7e78b and 29e1cdf.

📒 Files selected for processing (1)
  • studio/package.json
✅ Files skipped from review due to trivial changes (1)
  • studio/package.json

Walkthrough

CI and action Node versions were updated: the action input default pinned to 22.x (TODO to revert), CI matrix tests 22.x and 24.x. prettier was added to studio dependencies and a Prettier plugin import in a studio component was changed from a namespace to a default import.

Changes

Cohort / File(s) Summary
Node Action Configuration
​.github/actions/node/action.yaml
Changed inputs.node-version default from lts/* to 22.x and added a TODO comment about reverting after Node 20 EOL.
CI Workflow Matrix
​.github/workflows/cli-ci.yaml
Updated build_test_node_matrix Node versions from 20.x/22.x to 22.x/24.x for install and test jobs.
Studio package manifest
studio/package.json
Added prettier to studio dependencies (version referenced via catalog:).
Studio component import
studio/src/components/analytics/trace-details.tsx
Switched prettier/plugins/estree import from a namespace to a default import and adjusted its usage in prettier.format plugin list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: dropping Node.js 20 support, which aligns with all modifications across configuration files, workflows, and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 3/5 reviews remaining, refill in 19 minutes and 51 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.47%. Comparing base (b70a55b) to head (29e1cdf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
+ Coverage   46.29%   47.47%   +1.17%     
==========================================
  Files        1045     1065      +20     
  Lines      139820   144316    +4496     
  Branches     8789     9791    +1002     
==========================================
+ Hits        64733    68509    +3776     
- Misses      73334    74021     +687     
- Partials     1753     1786      +33     
Files with missing lines Coverage Δ
studio/src/components/analytics/trace-details.tsx 0.00% <ø> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/actions/node/action.yaml:
- Around line 5-7: Update the action metadata so the description matches the
actual default and make the TODO actionable: change the description value to
state that the default node version is '22.x' (instead of claiming 'lts'), and
revise the inline TODO comment to note that Node 20 reaches EOL on 2026-04-30
and that the plan is to revert the default to 'lts/*' after that date; make sure
to keep the default: '22.x' entry intact and clearly document the temporary
nature of this override.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3deed46b-f4e3-42d1-9106-44e33ed81f80

📥 Commits

Reviewing files that changed from the base of the PR and between 403bd79 and ccb7c22.

📒 Files selected for processing (2)
  • .github/actions/node/action.yaml
  • .github/workflows/cli-ci.yaml

Comment thread .github/actions/node/action.yaml Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-3ee43131a71887559e446b558e8e0e437079878e

@comatory comatory marked this pull request as ready for review April 29, 2026 07:43
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@comatory comatory requested a review from devsergiy April 29, 2026 07:43
@comatory comatory force-pushed the ondrej/eng-9463-cosmomonorepo-drop-nodejs-v20-support branch from b2b79fb to da7a679 Compare April 29, 2026 07:47
@comatory comatory enabled auto-merge (squash) April 29, 2026 07:52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/cli-ci.yaml:
- Line 74: Update the Node version statement in cli/README.md to match the CI
and root package.json engine requirement: change the current "Node.js v20 LTS or
higher" wording to "Node.js v22+ (>=22.11.0)" or equivalent phrasing that
reflects the exact engine floor from the root package.json's engines field;
ensure the README text and any contributor setup notes consistently reference
Node 22+ so they align with the CI workflow change (node-version: ["22.x",
"24.x"]) and the package.json engines entry.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68ca599f-0059-4ea7-85ca-7045282dd715

📥 Commits

Reviewing files that changed from the base of the PR and between b2b79fb and da7a679.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .github/actions/node/action.yaml
  • .github/workflows/cli-ci.yaml
  • studio/package.json
  • studio/src/components/analytics/trace-details.tsx
✅ Files skipped from review due to trivial changes (1)
  • studio/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/actions/node/action.yaml

Comment thread .github/workflows/cli-ci.yaml
Copy link
Copy Markdown
Member

@Aenimus Aenimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@comatory comatory merged commit 7a61b3c into main Apr 29, 2026
57 checks passed
@comatory comatory deleted the ondrej/eng-9463-cosmomonorepo-drop-nodejs-v20-support branch April 29, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants