Skip to content

fix: remediate several vulnerabilities#2787

Merged
pepol merged 7 commits intomainfrom
peter/eng-8989-remediate-medium-vulnerabilities-april-due-april-22
Apr 24, 2026
Merged

fix: remediate several vulnerabilities#2787
pepol merged 7 commits intomainfrom
peter/eng-8989-remediate-medium-vulnerabilities-april-due-april-22

Conversation

@pepol
Copy link
Copy Markdown
Member

@pepol pepol commented Apr 22, 2026

Summary by CodeRabbit

  • Chores

    • Updated runtime and framework dependencies across packages to the latest stable versions for improved performance and security updates.
    • Added version pinning for additional dependencies to ensure consistent and predictable dependency resolution during builds.
  • Documentation

    • Enhanced README documentation with improved formatting, spacing, and overall consistency throughout the guides.
  • Style

    • Refined TypeScript configuration file formatting for enhanced consistency.

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 239abdfc-0207-417d-8ffd-3159b73744e8

📥 Commits

Reviewing files that changed from the base of the PR and between 3607c59 and 4c7b60a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • admission-server/README.md
  • admission-server/tsconfig.json
  • cli/package.json
  • package.json
  • router/internal/graphiql/graphiql.html
  • studio/package.json
✅ Files skipped from review due to trivial changes (3)
  • studio/package.json
  • admission-server/tsconfig.json
  • admission-server/README.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • package.json
  • cli/package.json

Walkthrough

This PR updates multiple dependency versions across the project: ajv (8.17.1→8.18.0) in CLI, next (15.4.11→15.5.15) in root and studio packages, and adds new pnpm overrides for markdown-it (14.1.1) and lodash (4.18.1). Documentation and TypeScript configuration files are also reformatted.

Changes

Cohort / File(s) Summary
Dependency Version Updates
cli/package.json, package.json, studio/package.json
Updates ajv to 8.18.0 in CLI package, bumps next from 15.4.11 to 15.5.15 in root and studio packages, and adds pnpm overrides for markdown-it (14.1.1) and lodash (4.18.1).
Documentation and Configuration Formatting
admission-server/README.md, admission-server/tsconfig.json
Adds blank lines around code blocks, removes trailing whitespace, adds terminal newlines, and reformats tsconfig.json types array to single-line format.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remediate several vulnerabilities' accurately summarizes the main objective of the PR, which is to address multiple CVEs across various packages by upgrading dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.52%. Comparing base (e95aaed) to head (4c7b60a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2787      +/-   ##
==========================================
+ Coverage   46.28%   47.52%   +1.24%     
==========================================
  Files        1045     1065      +20     
  Lines      139773   144269    +4496     
  Branches     8768     9767     +999     
==========================================
+ Hits        64687    68571    +3884     
- Misses      73332    73925     +593     
- Partials     1754     1773      +19     

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-aeb37bd78ae5e86f5c2af1ceb53cb53a78e17b61-nonroot

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

106-107: Use caret ranges instead of unbounded versions for stability.

>=14.1.1 and >=4.18.1 allow floating to future major versions, risking uncontrolled upgrades and potential breakage. Use ^14.1.1 and ^4.18.1 for reproducible, bounded upgrades within the same major line.

Recommended override
-      "markdown-it": ">=14.1.1",
-      "lodash": ">=4.18.1"
+      "markdown-it": "^14.1.1",
+      "lodash": "^4.18.1"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 106 - 107, The package.json currently uses
unbounded version ranges ("markdown-it": ">=14.1.1" and "lodash": ">=4.18.1")
which can float to future major releases; update these to caret ranges
("markdown-it": "^14.1.1" and "lodash": "^4.18.1") so upgrades remain within the
same major version, ensuring more stable, reproducible dependency
resolution—locate the dependency entries for "markdown-it" and "lodash" in
package.json and replace the ">=" prefixes with "^".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@package.json`:
- Around line 106-107: The package.json currently uses unbounded version ranges
("markdown-it": ">=14.1.1" and "lodash": ">=4.18.1") which can float to future
major releases; update these to caret ranges ("markdown-it": "^14.1.1" and
"lodash": "^4.18.1") so upgrades remain within the same major version, ensuring
more stable, reproducible dependency resolution—locate the dependency entries
for "markdown-it" and "lodash" in package.json and replace the ">=" prefixes
with "^".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bc6c0bd4-c5e1-424a-afff-ef26d53f91bf

📥 Commits

Reviewing files that changed from the base of the PR and between e48e072 and 796f907.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • cli/package.json
  • composition/package.json
  • controlplane/package.json
  • package.json
  • playground/package.json
  • protographic/package.json
  • studio/package.json

@pepol pepol force-pushed the peter/eng-8989-remediate-medium-vulnerabilities-april-due-april-22 branch from c5476db to 3607c59 Compare April 24, 2026 08:48
pepol and others added 6 commits April 24, 2026 16:34
Resolves medium severity vulnerability in ajv package.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resolves medium severity vulnerability in transitive markdown-it
dependency used by graphiql, prosemirror-markdown, and tiptap-markdown.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Upgrades lodash in controlplane, composition, studio, playground and
lodash-es in cli, protographic. Adds pnpm override for lodash>=4.18.1
to cover transitive dependencies (inquirer).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Updates Next.js in studio and the root pnpm override to resolve
medium severity vulnerability requiring >= 15.5.10.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pepol pepol force-pushed the peter/eng-8989-remediate-medium-vulnerabilities-april-due-april-22 branch from 3607c59 to 4c7b60a Compare April 24, 2026 14:41
Copy link
Copy Markdown
Member

@Aenimus Aenimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pepol pepol merged commit fdd035b into main Apr 24, 2026
56 checks passed
@pepol pepol deleted the peter/eng-8989-remediate-medium-vulnerabilities-april-due-april-22 branch April 24, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants