feat: upgrade connect v1 to v2#2705
Open
JivusAyrus wants to merge 65 commits intomainfrom
Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…gen-connect-es Remove protoc-gen-connect-es plugin from buf.ts.gen.yaml since protoc-gen-es v2 now generates service descriptors directly in _pb.ts files. Delete stale *_connect.ts files that are no longer generated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix duplicate imports in builder.ts and graphql-configuration.ts by separating value imports (schemas, enums) from type-only imports (message types) - Replace Partial<> with MessageInitShape<> for V2 protobuf message init - Update tests to use standalone toJsonString() instead of instance method Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
In protobuf V2, PlainMessage<T> is no longer needed as messages are plain objects by default. Removed all 646 occurrences across 193 files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…omposition/webhooks Remove explicit return type annotations and handleError generics from all handlers, letting TypeScript infer types from ServiceImpl. Fix duplicate imports, instance methods, and PartialMessage usage in composition, repositories, and webhook files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix re-exports in index.ts to use `export type` for message types (isolatedModules compliance) - Remove duplicate type imports for LookupType/OperationType enums in sdl-to-mapping-visitor.ts - Update test files to use standalone `toJson(schema, message)` instead of the removed instance method `.toJson()` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Alias Client import to resolve naming conflict with local Client interface - Convert .toJsonString() instance method to standalone toJsonString() function - Replace PartialMessage with create() for GitInfo construction - Fix duplicate identifier errors by consolidating value/type imports - Fix CompositionWarning type in json-check-schema-output-builder - Update test files to use any for mock protobuf responses Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reorder node:* imports before @bufbuild/protobuf imports and switch type-only imports to use `import type` syntax for protobuf V2 generated types that only exist in .d.ts files. Also fix Prettier formatting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Strip $typeName from JSON output in JsonCheckSchemaOutputBuilder and update test expectations for V2 enum serialization and object equality. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address nominal typing issues introduced by protobuf V2 migration: - Remove PartialMessage imports (no longer exported) - Add type assertions for PublishFederatedSubgraphResponse -> CreateFederatedSubgraphResponse - Add type assertions for SchemaChange[] -> OverrideChange[] - Remove userID from RestoreOrganizationRequest (field removed from proto) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JivusAyrus
requested review from
a team,
Aenimus,
Noroth,
StarpTech,
dkorittki,
endigma,
jensneuse,
pepol,
thisisnithin and
wilsonrivera
as code owners
github-actions
Bot
added
studio
monorepo
controlplane
cli
connect
graphqlmetrics
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
thisisnithin
approved these changes
Apr 13, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ge initialization
…06-upgrade-connect-v1-to-v2
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Checklist