Skip to content

feat: list uncommitted files for git-dirty-check #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comatory merged 4 commits into from
Mar 20, 2026
Merged

feat: list uncommitted files for git-dirty-check #2669

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
482a5cc
feat: show list of uncomitted files when git-dirty-check fails
comatory Mar 19, 2026
2379ce0
Merge branch 'main' into ondrej/eng-9246-git-dirty-check-list-dirty-f…
comatory Mar 20, 2026
ddf88d0
Merge branch 'main' into ondrej/eng-9246-git-dirty-check-list-dirty-f…
comatory Mar 20, 2026
a817334
fix: build_test not being triggered
comatory Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/actions/git-dirty-check/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ runs:
- run: git diff --no-ext-diff --exit-code
id: git-dirty-check
shell: bash
- run: |
FILES=$(git diff --name-only --no-ext-diff | sed 's/^/* /')
echo "files<<EOF" >> $GITHUB_OUTPUT
echo "$FILES" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
Comment thread
coderabbitai[bot] marked this conversation as resolved.
id: dirty-files-list
shell: bash
if: failure() && steps.git-dirty-check.outcome == 'failure'
- uses: marocchino/sticky-pull-request-comment@v2
if: failure() && steps.git-dirty-check.outcome == 'failure'
with:
Expand All @@ -25,6 +33,15 @@ runs:
* Dependency mismatch for tools (protoc, etc). Ensure your local machine has same versions of tools as CI does
* Formatting drift, fix with `make format ${{ inputs.package-name }}` / `pnpm format ${{ inputs.package-name }}`

---

<details>
<summary>Dirty files</summary>

${{ steps.dirty-files-list.outputs.files }}

</details>

- uses: marocchino/sticky-pull-request-comment@v2
if: success() && steps.git-dirty-check.outcome == 'success'
with:
Expand Down
Loading