Skip to content

chore(demo): fix code generation for cost directives #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysmolski merged 8 commits into from
Mar 19, 2026
Merged

chore(demo): fix code generation for cost directives #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5b43f8
chore(demo): fix code generation for cost directives
ysmolski Mar 19, 2026
f186a0f
bump router in tests
ysmolski Mar 19, 2026
18d9e49
fix runtime resolvers
ysmolski Mar 19, 2026
a5f3b70
add github action to verify this in CI
ysmolski Mar 19, 2026
d9b7958
verify that config is up to date in CI
ysmolski Mar 19, 2026
6b3ae0b
fix typo
ysmolski Mar 19, 2026
1876f77
remove unneeded env var
ysmolski Mar 19, 2026
21b3192
Merge branch 'main' into yury/fix_demo_generate
ysmolski Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/demo-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Demo CI
on:
pull_request:
paths:
- "demo/**/*"
- ".github/workflows/demo-ci.yaml"

concurrency:
group: ${{github.workflow}}-${{github.head_ref}}
cancel-in-progress: true
Comment thread
ysmolski marked this conversation as resolved.

env:
CI: true

jobs:
build_test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/go

- name: Generate code
working-directory: demo
run: make generate

- uses: ./.github/actions/git-dirty-check
with:
package-name: demo
17 changes: 13 additions & 4 deletions .github/workflows/router-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,13 @@ jobs:
with:
bun-version: 1.2.15

- name: Generate code
- name: Generate Go code
run: make generate-go

- name: Generate test configs from demo
working-directory: ./router-tests
run: ./update-config-no-edg.sh

- uses: ./.github/actions/git-dirty-check
with:
package-name: router
Expand Down Expand Up @@ -155,11 +159,16 @@ jobs:
with:
bun-version: 1.2.15

- name: Generate code
- name: Generate Go code
run: make generate-go

- name: Check if git is not dirty after generating files
run: git diff --no-ext-diff --exit-code
- name: Generate test configs from demo
working-directory: ./router-tests
run: ./update-config-no-edg.sh

- uses: ./.github/actions/git-dirty-check
with:
package-name: router

- name: Install dependencies
working-directory: ./router
Expand Down
11 changes: 6 additions & 5 deletions demo/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ require (
github.com/rs/cors v1.11.0
github.com/vektah/gqlparser/v2 v2.5.30
github.com/wundergraph/cosmo/composition-go v0.0.0-20250820135159-bf8852195d3f
github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/router-tests v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/router v0.0.0-20260318232543-0e5fa811a191
github.com/wundergraph/cosmo/router-tests v0.0.0-20260318232543-0e5fa811a191
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0
go.opentelemetry.io/otel v1.36.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.33.0
Expand All @@ -23,7 +23,8 @@ require (
)

require (
connectrpc.com/connect v1.16.2 // indirect
connectrpc.com/connect v1.19.1 // indirect
connectrpc.com/vanguard v0.3.0 // indirect
github.com/KimMachineGun/automemlimit v0.6.1 // indirect
github.com/MicahParks/jwkset v0.11.0 // indirect
github.com/MicahParks/keyfunc/v3 v3.6.2 // indirect
Expand Down Expand Up @@ -145,10 +146,10 @@ require (
github.com/urfave/cli/v2 v2.27.7 // indirect
github.com/vbatts/tar-split v0.12.1 // indirect
github.com/wk8/go-ordered-map/v2 v2.1.8 // indirect
github.com/wundergraph/astjson v1.0.0 // indirect
github.com/wundergraph/astjson v1.1.0 // indirect
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e // indirect
github.com/wundergraph/go-arena v1.1.0 // indirect
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.248 // indirect
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.265 // indirect
Comment thread
ysmolski marked this conversation as resolved.
github.com/xrash/smetrics v0.0.0-20250705151800-55b8f293f342 // indirect
github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
github.com/yusufpapurcu/wmi v1.2.4 // indirect
Expand Down
26 changes: 14 additions & 12 deletions demo/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
connectrpc.com/connect v1.16.2 h1:ybd6y+ls7GOlb7Bh5C8+ghA6SvCBajHwxssO2CGFjqE=
connectrpc.com/connect v1.16.2/go.mod h1:n2kgwskMHXC+lVqb18wngEpF95ldBHXjZYJussz5FRc=
connectrpc.com/connect v1.19.1 h1:R5M57z05+90EfEvCY1b7hBxDVOUl45PrtXtAV2fOC14=
connectrpc.com/connect v1.19.1/go.mod h1:tN20fjdGlewnSFeZxLKb0xwIZ6ozc3OQs2hTXy4du9w=
connectrpc.com/vanguard v0.3.0 h1:prUKFm8rYDwvpvnOSoqdUowPMK0tRA0pbSrQoMd6Zng=
connectrpc.com/vanguard v0.3.0/go.mod h1:nxQ7+N6qhBiQczqGwdTw4oCqx1rDryIt20cEdECqToM=
github.com/99designs/gqlgen v0.17.76 h1:YsJBcfACWmXWU2t1yCjoGdOmqcTfOFpjbLAE443fmYI=
github.com/99designs/gqlgen v0.17.76/go.mod h1:miiU+PkAnTIDKMQ1BseUOIVeQHoiwYDZGCswoxl7xec=
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
Expand Down Expand Up @@ -187,8 +189,8 @@ github.com/jensneuse/byte-template v0.0.0-20231025215717-69252eb3ed56 h1:wo26fh6
github.com/jensneuse/byte-template v0.0.0-20231025215717-69252eb3ed56/go.mod h1:0D5r/VSW6D/o65rKLL9xk7sZxL2+oku2HvFPYeIMFr4=
github.com/jensneuse/diffview v1.0.0 h1:4b6FQJ7y3295JUHU3tRko6euyEboL825ZsXeZZM47Z4=
github.com/jensneuse/diffview v1.0.0/go.mod h1:i6IacuD8LnEaPuiyzMHA+Wfz5mAuycMOf3R/orUY9y4=
github.com/jhump/protoreflect v1.15.1 h1:HUMERORf3I3ZdX05WaQ6MIpd/NJ434hTp5YiKgfCL6c=
github.com/jhump/protoreflect v1.15.1/go.mod h1:jD/2GMKKE6OqX8qTjhADU1e6DShO+gavG9e0Q693nKo=
github.com/jhump/protoreflect v1.17.0 h1:qOEr613fac2lOuTgWN4tPAtLL7fUSbuJL5X5XumQh94=
github.com/jhump/protoreflect v1.17.0/go.mod h1:h9+vUUL38jiBzck8ck+6G/aeMX8Z4QUY/NiJPwPNi+8=
github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y=
github.com/josharian/native v1.1.0 h1:uuaP0hAbW7Y4l0ZRQ6C9zfb7Mg1mbFKry/xzDAfmtLA=
github.com/josharian/native v1.1.0/go.mod h1:7X/raswPFr05uY3HiLlYeyQntB6OO7E/d2Cu7qoaN2w=
Expand Down Expand Up @@ -371,20 +373,20 @@ github.com/vektah/gqlparser/v2 v2.5.30 h1:EqLwGAFLIzt1wpx1IPpY67DwUujF1OfzgEyDsL
github.com/vektah/gqlparser/v2 v2.5.30/go.mod h1:D1/VCZtV3LPnQrcPBeR/q5jkSQIPti0uYCP/RI0gIeo=
github.com/wk8/go-ordered-map/v2 v2.1.8 h1:5h/BUHu93oj4gIdvHHHGsScSTMijfx5PeYkE/fJgbpc=
github.com/wk8/go-ordered-map/v2 v2.1.8/go.mod h1:5nJHM5DyteebpVlHnWMV0rPz6Zp7+xBAnxjb1X5vnTw=
github.com/wundergraph/astjson v1.0.0 h1:rETLJuQkMWWW03HCF6WBttEBOu8gi5vznj5KEUPVV2Q=
github.com/wundergraph/astjson v1.0.0/go.mod h1:h12D/dxxnedtLzsKyBLK7/Oe4TAoGpRVC9nDpDrZSWw=
github.com/wundergraph/astjson v1.1.0 h1:xORDosrZ87zQFJwNGe/HIHXqzpdHOFmqWgykCLVL040=
github.com/wundergraph/astjson v1.1.0/go.mod h1:h12D/dxxnedtLzsKyBLK7/Oe4TAoGpRVC9nDpDrZSWw=
github.com/wundergraph/cosmo/composition-go v0.0.0-20250820135159-bf8852195d3f h1:TjxywtqT+D6Qa/WGg1Vqn4ogT6P7M+iuUxPgDds1/kU=
github.com/wundergraph/cosmo/composition-go v0.0.0-20250820135159-bf8852195d3f/go.mod h1:S3y/4/28Iut0SHMbmfXXa/6qyP55BA2rS4K3VI8A4Pg=
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e h1:VdJNlsiyWYxJzAD3jEe+DAQdzxkf9btD8qQNYNU+xQU=
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e/go.mod h1:WZ0yBeaDSGHqDMcQrP1JRYgCj9atF7ORXF8srnd2Sro=
github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850 h1:KpamF+1Vo3Dm8gcayYXTPZuKgPw/zVgJAI/NeODVVeU=
github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850/go.mod h1:We+sYVVSnWyylJRHpELaR0GOZndk1UI4gtf2zceZEmA=
github.com/wundergraph/cosmo/router-tests v0.0.0-20260213130455-6e3277e7b850 h1:ddKb9MX85UdRTrLzzYFnob2dU0VHhKqNSwUa0UEr1cs=
github.com/wundergraph/cosmo/router-tests v0.0.0-20260213130455-6e3277e7b850/go.mod h1:T5l+RrKg83m7G5OLJeHO9fEJT3zUeZ/VfKf+k98Ol0g=
github.com/wundergraph/cosmo/router v0.0.0-20260318232543-0e5fa811a191 h1:PCEyCEchpG/2IY4uH0tizZQlqSKuspv4lHtiFbl+fZM=
github.com/wundergraph/cosmo/router v0.0.0-20260318232543-0e5fa811a191/go.mod h1:YawmJF/Oue/8PCCtP7x2smoRsKsL6h/wpjje5gqSOmw=
github.com/wundergraph/cosmo/router-tests v0.0.0-20260318232543-0e5fa811a191 h1:q4T4N463s+mhf7v3mEU4zW71qX1tBeT/IwD29oQ/wPM=
github.com/wundergraph/cosmo/router-tests v0.0.0-20260318232543-0e5fa811a191/go.mod h1:x/MoiTDyaRkTrfh5EMJTSzGLsB1eZ8mI/zrZgRRAvhA=
github.com/wundergraph/go-arena v1.1.0 h1:9+wSRkJAkA2vbYHp6s8tEGhPViRGQNGXqPHT0QzhdIc=
github.com/wundergraph/go-arena v1.1.0/go.mod h1:ROOysEHWJjLQ8FSfNxZCziagb7Qw2nXY3/vgKRh7eWw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.248 h1:+6Byi9AMVT2eP6hJhNH6unRXjTtkzVs3fc/2XExbJpY=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.248/go.mod h1:MFbY0QI8ncF60DHs7yyyiyyhWyld0WE1JokiyTVY8j4=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.265 h1:KVmojt3oH13VX8Yr8NZ+fuOiruLyznderHITJs1MyWE=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.265/go.mod h1:HjTAO/cuICpu31IfHY9qmSPygx6Gza7Wt9hTSReTI+A=
github.com/xrash/smetrics v0.0.0-20250705151800-55b8f293f342 h1:FnBeRrxr7OU4VvAzt5X7s6266i6cSVkkFPS0TuXWbIg=
github.com/xrash/smetrics v0.0.0-20250705151800-55b8f293f342/go.mod h1:Ohn+xnUBiLI6FVj/9LpzZWtj1/D6lUovWYBkxHVV3aM=
github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4=
Expand Down
4 changes: 4 additions & 0 deletions demo/pkg/subgraphs/employees/gqlgen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ resolver:
package: subgraph

directives:
cost:
skip_runtime: true
listSize:
skip_runtime: true
openfed__requireFetchReasons:
skip_runtime: true

Expand Down
25 changes: 20 additions & 5 deletions demo/pkg/subgraphs/employees/subgraph/generated/generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions demo/pkg/subgraphs/employees/subgraph/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,21 @@ extend schema
]
)

directive @cost(weight: Int!) on
| ARGUMENT_DEFINITION
| ENUM
| FIELD_DEFINITION
| INPUT_FIELD_DEFINITION
| OBJECT
| SCALAR

directive @listSize(
assumedSize: Int,
slicingArguments: [String!],
sizedFields: [String!],
requireOneSlicingArgument: Boolean = true
) on FIELD_DEFINITION

Comment thread
ysmolski marked this conversation as resolved.
directive @goField(
forceResolver: Boolean
name: String
Expand Down
6 changes: 6 additions & 0 deletions demo/pkg/subgraphs/products/gqlgen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ resolver:
dir: subgraph
package: subgraph

directives:
cost:
skip_runtime: true
listSize:
skip_runtime: true

# Optional: turn on use `gqlgen:"fieldName"` tags in your models
# struct_tag: json

Expand Down
41 changes: 37 additions & 4 deletions demo/pkg/subgraphs/products/subgraph/generated/generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions demo/pkg/subgraphs/products/subgraph/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
extend schema
@link(url: "https://specs.apollo.dev/federation/v2.5", import: ["@authenticated", "@composeDirective", "@external", "@extends", "@inaccessible", "@interfaceObject", "@override", "@provides", "@key", "@requires", "@requiresScopes", "@shareable", "@tag"])

directive @cost(weight: Int!) on
| ARGUMENT_DEFINITION
| ENUM
| FIELD_DEFINITION
| INPUT_FIELD_DEFINITION
| OBJECT
| SCALAR

directive @listSize(
assumedSize: Int,
slicingArguments: [String!],
sizedFields: [String!],
requireOneSlicingArgument: Boolean = true
) on FIELD_DEFINITION

schema {
query: Queries
mutation: Mutation
Expand Down
4 changes: 2 additions & 2 deletions router-tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ require (
github.com/twmb/franz-go v1.16.1
github.com/twmb/franz-go/pkg/kadm v1.11.0
github.com/wundergraph/astjson v1.1.0
github.com/wundergraph/cosmo/demo v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/demo v0.0.0-20260319123623-f186a0f724f6
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e
github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/router v0.0.0-20260319123623-f186a0f724f6
github.com/wundergraph/cosmo/router-plugin v0.0.0-20250808194725-de123ba1c65e
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.265
go.opentelemetry.io/otel v1.39.0
Expand Down
Loading
Loading