feat: add subgraph check extension outcome to proposals screen

[wilsonrivera]

Summary by CodeRabbit

• New Features

  • Added an "Extension" badge to schema check results showing extension delivery status and indicating extension errors.

• Improvements

  • Check evaluations now factor in extension delivery and error information, so proposal and schema check statuses surface extension-related failures more accurately.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/docs-website.
• I have read the Contributors Guide.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9cce6e11-2222-463d-9226-8702a0d9fb2f

📥 Commits

Reviewing files that changed from the base of the PR and between 7f027fa and 3469393.

📒 Files selected for processing (1)

• studio/src/pages/[organizationSlug]/[namespace]/graph/[slug]/proposals/[proposalId]/index.tsx

---

Walkthrough

Propagates two optional schema-check extension fields (checkExtensionDeliveryId, checkExtensionErrorMessage) through core logic, repositories, service summary, and UI; updates isCheckSuccessful to accept these fields and return false when both are present.

Changes

Cohort / File(s)	Summary
Core Check Logic controlplane/src/core/util.ts	Adds checkExtensionDeliveryId?: string and checkExtensionErrorMessage?: string to isCheckSuccessful parameters and a guard that returns false when both are truthy.
Service / Summary controlplane/src/core/bufservices/check/getCheckSummary.ts	Passes the two new extension fields into per-check success evaluation when constructing check summaries.
Repositories / Data Retrieval controlplane/src/core/repositories/ProposalRepository.ts, controlplane/src/core/repositories/SchemaCheckRepository.ts	Selects checkExtensionDeliveryId and checkExtensionErrorMessage from schemaChecks, propagates them into returned check objects and into isCheckSuccessful invocations.
Frontend — Proposal UI studio/src/pages/.../proposals/[proposalId]/index.tsx	Adds the two props to ProposalDetails, wires them into success computation, and renders an "Extension" badge driven by deliveryId/error presence.
UI Helper studio/src/components/check-badge-icon.tsx	Coerces checkExtensionError with Boolean(...) when computing badge icon to handle undefined values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: issue subgraph check extensions for proposals #2615: Modifies and propagates checkExtensionDeliveryId and checkExtensionErrorMessage through schema-check and repository flows — strong overlap with these changes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding subgraph check extension outcome visibility to the proposals screen.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[StarpTech]

LGTM

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@studio/src/pages/`[organizationSlug]/[namespace]/graph/[slug]/proposals/[proposalId]/index.tsx:
- Around line 480-481: The check status logic ignores the new extension fields
(checkExtensionDeliveryId, checkExtensionErrorMessage) when calling
isCheckSuccessful, causing badges to show passed while extension tasks failed;
update every call to isCheckSuccessful in the proposal component (the call
around where checkExtensionDeliveryId and checkExtensionErrorMessage are
available, lines ~483-497) to pass those extension fields as arguments so the
function can consider them when computing success, and ensure the
isCheckSuccessful signature usage matches (include checkExtensionDeliveryId and
checkExtensionErrorMessage in the parameter list you pass).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f814ed6d-38db-4641-a3bb-4dd22cd5b0d9

📥 Commits

Reviewing files that changed from the base of the PR and between 3426dd3 and 1ba1cea.

📒 Files selected for processing (5)

• controlplane/src/core/bufservices/check/getCheckSummary.ts
• controlplane/src/core/repositories/ProposalRepository.ts
• controlplane/src/core/repositories/SchemaCheckRepository.ts
• controlplane/src/core/util.ts
• studio/src/pages/[organizationSlug]/[namespace]/graph/[slug]/proposals/[proposalId]/index.tsx

[codecov]

Codecov Report

❌ Patch coverage is 42.85714% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.58%. Comparing base (3426dd3) to head (3469393).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
[...ace]/graph/[slug]/proposals/[proposalId]/index.tsx](https://app.codecov.io/gh/wundergraph/cosmo/pull/2661?src=pr&el=tree&filepath=studio%2Fsrc%2Fpages%2F%5BorganizationSlug%5D%2F%5Bnamespace%5D%2Fgraph%2F%5Bslug%5D%2Fproposals%2F%5BproposalId%5D%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wundergraph#diff-c3R1ZGlvL3NyYy9wYWdlcy9bb3JnYW5pemF0aW9uU2x1Z10vW25hbWVzcGFjZV0vZ3JhcGgvW3NsdWddL3Byb3Bvc2Fscy9bcHJvcG9zYWxJZF0vaW5kZXgudHN4)	0.00%	17 Missing ⚠️
...ane/src/core/repositories/SchemaCheckRepository.ts	0.00%	2 Missing ⚠️
studio/src/components/check-badge-icon.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2661       +/-   ##
===========================================
- Coverage   89.54%   33.58%   -55.96%     
===========================================
  Files          20      601      +581     
  Lines        4360    84729    +80369     
  Branches     1199     5054     +3855     
===========================================
+ Hits         3904    28460    +24556     
- Misses        456    55961    +55505     
- Partials        0      308      +308     

Files with missing lines	Coverage Δ
...lane/src/core/bufservices/check/getCheckSummary.ts	63.70% <100.00%> (ø)
...lplane/src/core/repositories/ProposalRepository.ts	94.35% <100.00%> (ø)
controlplane/src/core/util.ts	80.91% <100.00%> (ø)
studio/src/components/check-badge-icon.tsx	0.00% <0.00%> (ø)
...ane/src/core/repositories/SchemaCheckRepository.ts	70.95% <0.00%> (ø)
[...ace]/graph/[slug]/proposals/[proposalId]/index.tsx](https://app.codecov.io/gh/wundergraph/cosmo/pull/2661?src=pr&el=tree&filepath=studio%2Fsrc%2Fpages%2F%5BorganizationSlug%5D%2F%5Bnamespace%5D%2Fgraph%2F%5Bslug%5D%2Fproposals%2F%5BproposalId%5D%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wundergraph#diff-c3R1ZGlvL3NyYy9wYWdlcy9bb3JnYW5pemF0aW9uU2x1Z10vW25hbWVzcGFjZV0vZ3JhcGgvW3NsdWddL3Byb3Bvc2Fscy9bcHJvcG9zYWxJZF0vaW5kZXgudHN4)	0.00% <0.00%> (ø)

... and 615 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.