Skip to content

fix: flag option as experimental #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alepane21 merged 7 commits into from
Mar 11, 2026
Merged

fix: flag option as experimental #2628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1eed39a
fix: flag option as experimental
dkorittki Mar 11, 2026
1cc1bbf
chore: Remove config nesting
dkorittki Mar 11, 2026
716974b
Merge branch 'main' into dominik/eng-9159-make-config-option-experime…
alepane21 Mar 11, 2026
416a4d1
fix: improve naming
alepane21 Mar 11, 2026
a3abd17
Merge branch 'main' into dominik/eng-9159-make-config-option-experime…
alepane21 Mar 11, 2026
e9f38f3
fix: remove env for nats configs
alepane21 Mar 11, 2026
ba4353f
Merge remote-tracking branch 'origin/dominik/eng-9159-make-config-opt…
alepane21 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion router/pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ type NatsEventSource struct {
ID string `yaml:"id,omitempty"`
URL string `yaml:"url,omitempty"`
Authentication *NatsAuthentication `yaml:"authentication,omitempty"`
Consumers NatsConsumersConfiguration `yaml:"consumers,omitempty"`
Consumers NatsConsumersConfiguration `yaml:"experiment_consumers,omitempty"`
}

func (n NatsEventSource) GetID() string {
Expand Down
6 changes: 3 additions & 3 deletions router/pkg/config/config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2581,9 +2581,9 @@
}
]
},
"consumers": {
"experiment_consumers": {
"type": "object",
"description": "Configuration for JetStream consumers managed by this NATS provider.",
"description": "Configuration for JetStream consumers managed by this NATS provider. NOTE: This option and it's suboptions are experimental and may change at any time.",
"additionalProperties": false,
"properties": {
"durable": {
Expand All @@ -2593,7 +2593,7 @@
"properties": {
"delete_on_shutdown": {
"type": "boolean",
"description": "When enabled, all durable JetStream consumers created by this provider are deleted when the router shuts down normally. Defaults to false.",
"description": "When enabled, all durable JetStream consumers created by this provider are deleted when the router shuts down normally. NOTE: This option is experimental and may change at any time. Defaults to false.",
"default": false
}
}
Expand Down
Loading