Skip to content

fix(mcp): reset registeredTools between reloads to prevent false tool name collisions#2625

Merged
asoorm merged 2 commits into
mainfrom
ahmet/eng-9158-mcp-registeredtools-grows-unbounded-across-config-reloads
Mar 12, 2026
Merged

fix(mcp): reset registeredTools between reloads to prevent false tool name collisions#2625
asoorm merged 2 commits into
mainfrom
ahmet/eng-9158-mcp-registeredtools-grows-unbounded-across-config-reloads

fix(mcp): improve test assertions and naming per review feedback

ca84c26
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2026 in 1s

62.90% (target 30.00%)

View this Pull Request on Codecov

62.90% (target 30.00%)

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.90%. Comparing base (670f75d) to head (ca84c26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2625      +/-   ##
==========================================
+ Coverage   62.41%   62.90%   +0.48%     
==========================================
  Files         244      244              
  Lines       25826    25826              
==========================================
+ Hits        16119    16245     +126     
+ Misses       8326     8209     -117     
+ Partials     1381     1372       -9     
Files with missing lines Coverage Δ
router/pkg/mcpserver/server.go 79.06% <100.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.