Skip to content

fix: flaky tests for utf8 warning test #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SkArchon wants to merge 8 commits into from
Closed

fix: flaky tests for utf8 warning test #2597

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9736954
fix: flaky tests
SkArchon Mar 6, 2026
cfa19f7
fix: updates
SkArchon Mar 6, 2026
03cf2da
fix: add flaky section
SkArchon Mar 6, 2026
c175fee
fix: updates
SkArchon Mar 6, 2026
ee6efbc
fix: flaky tests
SkArchon Mar 6, 2026
bb9517f
fix: updates
SkArchon Mar 6, 2026
38de75f
fix: updates
SkArchon Mar 6, 2026
c2ce70e
Merge branch 'main' into milinda/fix-flaky-tests
SkArchon Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions router-tests/telemetry/attribute_processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"fmt"
"strings"
"testing"
"time"

"github.com/stretchr/testify/require"
"github.com/wundergraph/cosmo/router-tests/testenv"
Expand Down Expand Up @@ -189,25 +188,17 @@ func TestAttributeProcessorIntegration(t *testing.T) {
})

t.Run("invalid UTF-8 export error logs config hint", func(t *testing.T) {
t.Parallel()

testenv.Run(t, &testenv.Config{
TraceExporter: &invalidUTF8Exporter{},
LogObservation: testenv.LogObservationConfig{
Enabled: true,
LogLevel: zapcore.ErrorLevel,
},
}, func(t *testing.T, xEnv *testenv.Environment) {
require.Eventually(t, func() bool {
res := xEnv.MakeGraphQLRequestOK(testenv.GraphQLRequest{
Query: `query { employees { id } }`,
})
if res.Response.StatusCode != 200 {
return false
}
logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
return len(logs) > 0
}, 10*time.Second, 500*time.Millisecond)
res := xEnv.MakeGraphQLRequestOK(testenv.GraphQLRequest{
Query: `query { employees { id } }`,
})
require.Equal(t, 200, res.Response.StatusCode)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
require.NotEmpty(t, logs)
Expand Down
Loading