Skip to content

fix: fix selecting parent of unique nodes #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devsergiy wants to merge 2 commits into from
Closed

fix: fix selecting parent of unique nodes #2592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e367407
chore: tmp engine version
devsergiy Mar 5, 2026
7459c47
Merge branch 'main' into sergiy/eng-9097-fix-wrong-external-parent-se…
Aenimus Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion router-tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ require (
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e
github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/router-plugin v0.0.0-20250808194725-de123ba1c65e
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.257
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.259.0.20260305233335-726700149835
go.opentelemetry.io/otel v1.36.0
go.opentelemetry.io/otel/sdk v1.36.0
go.opentelemetry.io/otel/sdk/metric v1.36.0
Expand Down
4 changes: 2 additions & 2 deletions router-tests/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ github.com/wundergraph/astjson v1.1.0 h1:xORDosrZ87zQFJwNGe/HIHXqzpdHOFmqWgykCLV
github.com/wundergraph/astjson v1.1.0/go.mod h1:h12D/dxxnedtLzsKyBLK7/Oe4TAoGpRVC9nDpDrZSWw=
github.com/wundergraph/go-arena v1.1.0 h1:9+wSRkJAkA2vbYHp6s8tEGhPViRGQNGXqPHT0QzhdIc=
github.com/wundergraph/go-arena v1.1.0/go.mod h1:ROOysEHWJjLQ8FSfNxZCziagb7Qw2nXY3/vgKRh7eWw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.257 h1:hGsaKXRkH3o8DkyizY48/wC1Q+NB1nfD9EKVA7Gc81Y=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.257/go.mod h1:gfmmrPd2khZONmwYE8RIfnGjwIG+RqL52jYiBzcUST8=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.259.0.20260305233335-726700149835 h1:sab4sGLCthZ7EhbcoHLAdSuNDCQSy0ehltKWn/uQ7cw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.259.0.20260305233335-726700149835/go.mod h1:gfmmrPd2khZONmwYE8RIfnGjwIG+RqL52jYiBzcUST8=
github.com/xrash/smetrics v0.0.0-20250705151800-55b8f293f342 h1:FnBeRrxr7OU4VvAzt5X7s6266i6cSVkkFPS0TuXWbIg=
github.com/xrash/smetrics v0.0.0-20250705151800-55b8f293f342/go.mod h1:Ohn+xnUBiLI6FVj/9LpzZWtj1/D6lUovWYBkxHVV3aM=
github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4=
Expand Down
2 changes: 1 addition & 1 deletion router/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ require (
github.com/tidwall/gjson v1.18.0
github.com/tidwall/sjson v1.2.5
github.com/twmb/franz-go v1.16.1
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.257
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.259.0.20260305233335-726700149835
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

github.com/wundergraph/graphql-go-tools v2.0.0-rc.259 commit 726700149835 changelog

💡 Result:

  • v2.0.0-rc.259 changelog (released 2026-03-05): Bug Fixes → “skip invocation for empty context in field resolvers” (PR fix: ignore internal cost for ristretto caches #1413, commit 5885c48). [1][2]
  • Commit 726700149835 (subject): “fix selecting parent of unique nodes” — changes v2/pkg/engine/plan/datasource_filter_visitor.go to stop walking up the parent chain when the parent is fully external (it now breaks instead of continuing). [3]

Sources: [1] Tags page (rc.259 notes), [2] Release page v2.0.0-rc.259, [3] Commit 726700149835.

🌐 Web query:

wundergraph graphql-go-tools v2 "parent of unique nodes" fix rc.259

💡 Result:

In wundergraph/graphql-go-tools v2, the GitHub tag/release v2.0.0-rc.259 (dated 2026-03-05) contains a single listed bug fix:

  • “skip invocation for empty context in field resolvers” (PR fix: ignore internal cost for ristretto caches #1413, commit 5885c48) — the engine avoids invoking nested field resolver RPCs when the parent data/context is missing/empty, returning null instead of making unnecessary calls. [1], [2]

I couldn’t find any release note, PR title, or commit message in rc.259 that matches the exact phrase “parent of unique nodes”. If you can paste the exact error/log line (or link the issue/PR), I can track the specific fix to the right tag/commit.

Sources: [1], [2]

🌐 Web query:

site:github.com wundergraph graphql-go-tools/v2 rc.259 rc.257 commits

💡 Result:

Commits included in wundergraph/graphql-go-tools between v2.0.0-rc.257 and v2.0.0-rc.259 (i.e., v2.0.0-rc.257...v2.0.0-rc.259) are these 5 commits: [1]

  1. 6fa1cdb — chore: move cost tests into separate file (PR #1418) [1]
  2. 3b4dbcb — fix: handle complex types inside inline fragments in gRPC execution plan (PR #1411) [1]
  3. 0bc474f — chore(master): release 2.0.0-rc.258 (PR #1425) [1]
  4. 5885c48 — fix: skip invocation for empty context in field resolvers (PR #1413) [1]
  5. 5940d31 — chore(master): release 2.0.0-rc.259 (PR #1427) [1]

The tags page also shows v2.0.0-rc.258 and v2.0.0-rc.259 were both created on Mar 5, 2026, with their release PRs (#1425, #1427) matching the commits above. [2]

Sources: [1] [2]

Clarify that the pinned commit contains the intended fix but is not in the rc.259 release notes.

The pseudo-version pins to commit 726700149835 which contains "fix selecting parent of unique nodes", but this fix is not listed in the v2.0.0-rc.259 (2026-03-05) changelog. The official rc.259 release documents only "skip invocation for empty context in field resolvers" (commit 5885c48). Confirm that commit 726700149835 is the correct intended fix before merge and verify it does not introduce regressions to the field resolver logic changes.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@router/go.mod` at line 34, The go.mod currently pseudo-pins
github.com/wundergraph/graphql-go-tools/v2 to commit 726700149835 claiming it
contains "fix selecting parent of unique nodes" but that commit isn't documented
in the rc.259 release notes; verify that commit 726700149835 in module
github.com/wundergraph/graphql-go-tools/v2 is the intended fix by checking the
commit diff and changelog, run the project's integration and unit tests
(including resolver/field-resolver and selection logic tests) against that
commit to detect regressions, and then either (A) update go.mod to point to the
official release that contains the fix (if one exists) or (B) keep the
pseudo-version but add a clear comment above the module line documenting the
exact commit hash and reason for pinning; if tests fail, revert the pin and open
a follow-up issue/pr discussing the conflicting changes in field resolver logic.

// Do not upgrade, it renames attributes we rely on
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0
go.opentelemetry.io/contrib/propagators/b3 v1.23.0
Expand Down
4 changes: 2 additions & 2 deletions router/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,8 @@ github.com/wundergraph/astjson v1.1.0 h1:xORDosrZ87zQFJwNGe/HIHXqzpdHOFmqWgykCLV
github.com/wundergraph/astjson v1.1.0/go.mod h1:h12D/dxxnedtLzsKyBLK7/Oe4TAoGpRVC9nDpDrZSWw=
github.com/wundergraph/go-arena v1.1.0 h1:9+wSRkJAkA2vbYHp6s8tEGhPViRGQNGXqPHT0QzhdIc=
github.com/wundergraph/go-arena v1.1.0/go.mod h1:ROOysEHWJjLQ8FSfNxZCziagb7Qw2nXY3/vgKRh7eWw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.257 h1:hGsaKXRkH3o8DkyizY48/wC1Q+NB1nfD9EKVA7Gc81Y=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.257/go.mod h1:gfmmrPd2khZONmwYE8RIfnGjwIG+RqL52jYiBzcUST8=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.259.0.20260305233335-726700149835 h1:sab4sGLCthZ7EhbcoHLAdSuNDCQSy0ehltKWn/uQ7cw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.259.0.20260305233335-726700149835/go.mod h1:gfmmrPd2khZONmwYE8RIfnGjwIG+RqL52jYiBzcUST8=
github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4=
github.com/yosida95/uritemplate/v3 v3.0.2/go.mod h1:ILOh0sOhIJR3+L/8afwt/kE++YT040gmv5BQTMR2HP4=
github.com/yuin/gopher-lua v1.1.1 h1:kYKnWBjvbNP4XLT3+bPEwAXJx262OhaHDWDVOPjL46M=
Expand Down
Loading