Skip to content

chore(router): gofmt#2576

Merged
dkorittki merged 1 commit intomainfrom
dominik/gofmt
Mar 3, 2026
Merged

chore(router): gofmt#2576
dkorittki merged 1 commit intomainfrom
dominik/gofmt

Conversation

@dkorittki
Copy link
Copy Markdown
Contributor

@dkorittki dkorittki commented Mar 3, 2026

Checklist

just gofmt formatting go code for router and router-tests. We could consider adding gofmt checks to CI.

Summary by CodeRabbit

  • Style
    • Applied formatting standardization across the codebase, including field alignment in declarations, blank line adjustments, and trailing newline normalization to improve code consistency.

@github-actions github-actions Bot added the router label Mar 3, 2026
@dkorittki dkorittki changed the title chore: gofmt chore(router): gofmt Mar 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 3, 2026

Walkthrough

This PR applies formatting and whitespace adjustments across multiple files in the router and router-tests packages, including blank line reflow, struct field alignment, and trailing newline normalization. No functional logic or behavioral changes are introduced.

Changes

Cohort / File(s) Summary
Test File Formatting
router-tests/connectrpc/*_test.go, router-tests/modules/verify-operation-context-values/module.go
Whitespace reflow: blank line adjustments and trailing newline normalization across test files.
Core Router Struct Alignment
router/core/context.go, router/core/operation_processor.go, router/core/plan_generator.go
Field alignment and formatting adjustments in struct declarations (OperationTimings, OperationProcessorOptions). No type or behavioral changes.
Router Package Files
router/pkg/config/config.go, router/pkg/connectrpc/handler_test.go, router/pkg/connectrpc/operation_loader.go, router/pkg/connectrpc/vanguard_service_test.go
Trailing newline normalization and blank line removal across package files.
Server Infrastructure
router/pkg/mcpserver/server.go
Blank line removal between function sections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: gofmt' accurately and concisely describes the PR's primary purpose of applying gofmt formatting to the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

Router image scan failed

❌ Security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-52b7ef6eb241d95ba1bdf576f69b2912cf7c39c3

Please check the security vulnerabilities found in the PR.

If you believe this is a false positive, please add the vulnerability to the .trivyignore file and re-run the scan.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.51%. Comparing base (1adf02c) to head (f98cce2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
router/core/plan_generator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2576       +/-   ##
===========================================
+ Coverage   36.94%   61.51%   +24.57%     
===========================================
  Files         964      242      -722     
  Lines      126281    25608   -100673     
  Branches     5153        0     -5153     
===========================================
- Hits        46657    15754    -30903     
+ Misses      77981     8509    -69472     
+ Partials     1643     1345      -298     
Files with missing lines Coverage Δ
router/core/context.go 73.19% <ø> (ø)
router/core/operation_processor.go 85.00% <100.00%> (ø)
router/pkg/config/config.go 80.51% <ø> (ø)
router/pkg/connectrpc/operation_loader.go 49.20% <ø> (ø)
router/pkg/mcpserver/server.go 79.06% <ø> (ø)
router/core/plan_generator.go 73.07% <0.00%> (ø)

... and 740 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkorittki dkorittki merged commit 2b15a4f into main Mar 3, 2026
46 of 55 checks passed
@dkorittki dkorittki deleted the dominik/gofmt branch March 3, 2026 08:58
dkorittki added a commit that referenced this pull request Mar 4, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Mar 30, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants