Skip to content

fix: handle fully external, unresolvable entity keys#2568

Merged
Aenimus merged 4 commits into
mainfrom
david/eng-9040-validate-true-external-keys
Feb 27, 2026
Merged

fix: handle fully external, unresolvable entity keys#2568
Aenimus merged 4 commits into
mainfrom
david/eng-9040-validate-true-external-keys

Merge branch 'main' into david/eng-9040-validate-true-external-keys

5827269
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2026 in 0s

33.29% (target 30.00%)

View this Pull Request on Codecov

33.29% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 92.02899% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.29%. Comparing base (9b69e59) to head (5827269).

Files with missing lines Patch % Lines
...aph/walker/root-field-walkers/root-field-walker.ts 72.22% 5 Missing ⚠️
...bility-graph/walker/entity-walker/entity-walker.ts 86.66% 4 Missing ⚠️
...graph/node-resolution-data/node-resolution-data.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2568       +/-   ##
===========================================
- Coverage   63.59%   33.29%   -30.30%     
===========================================
  Files         298      716      +418     
  Lines       41920    98762    +56842     
  Branches     4439     3649      -790     
===========================================
+ Hits        26657    32881     +6224     
- Misses      15241    64197    +48956     
- Partials       22     1684     +1662     
Files with missing lines Coverage Δ
composition/src/resolvability-graph/graph-nodes.ts 98.03% <100.00%> (ø)
composition/src/resolvability-graph/graph.ts 93.21% <100.00%> (ø)
...omposition/src/resolvability-graph/types/params.ts 100.00% <ø> (ø)
composition/src/resolvability-graph/types/types.ts 100.00% <ø> (ø)
composition/src/resolvability-graph/utils/utils.ts 99.36% <100.00%> (ø)
...ability-graph/walker/entity-walker/types/params.ts 100.00% <ø> (ø)
...ty-graph/walker/root-field-walkers/types/params.ts 100.00% <ø> (ø)
...omposition/src/v1/federation/federation-factory.ts 88.74% <100.00%> (ø)
...tion/src/v1/normalization/normalization-factory.ts 89.62% <100.00%> (ø)
composition/src/v1/normalization/utils.ts 93.93% <100.00%> (ø)
... and 3 more

... and 1001 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.