chore: exclude buf-generated protobuf files from CODEOWNERS#2547
Merged
chore: exclude buf-generated protobuf files from CODEOWNERS#2547
Conversation
Contributor
WalkthroughUpdated .github/CODEOWNERS with ownership entries for generated protobuf directories (/router/gen/, /connect-go/gen/, /graphqlmetrics/gen/, /connect/src/wg/) and minor formatting adjustments to existing entries. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/CODEOWNERS:
- Around line 32-36: The CODEOWNERS entries for the generated directories
(/router/gen/, /connect-go/gen/, /graphqlmetrics/gen/, /connect/src/wg/) are
invalid because they have no owners; remove these blank patterns or assign
explicit owner handles (e.g., `@org/team`) so GitHub recognizes them, or
alternatively remove the global "*" owner and explicitly list desired owned
paths excluding these generated directories and manage exclusions via GitHub
rulesets; update the .github/CODEOWNERS file by either deleting the four listed
lines or replacing each with a valid owner handle to resolve the invalid syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes review requirements for auto-generated protobuf files in
/router/gen//connect-go/gen//graphqlmetrics/gen//connect/src/wg/.These files are sourced from
/proto/and shouldn't require review from the directory-specific owners.Summary by CodeRabbit