Skip to content

chore: exclude buf-generated protobuf files from CODEOWNERS#2547

Merged
StarpTech merged 1 commit intomainfrom
jesse/no-generated-codeowners
Feb 23, 2026
Merged

chore: exclude buf-generated protobuf files from CODEOWNERS#2547
StarpTech merged 1 commit intomainfrom
jesse/no-generated-codeowners

Conversation

@endigma
Copy link
Copy Markdown
Member

@endigma endigma commented Feb 23, 2026

Removes review requirements for auto-generated protobuf files in

  • /router/gen/
  • /connect-go/gen/
  • /graphqlmetrics/gen/
  • /connect/src/wg/.

These files are sourced from /proto/ and shouldn't require review from the directory-specific owners.

Summary by CodeRabbit

  • Chores
    • Updated internal code ownership configuration to align ownership assignments with the current project structure and team responsibilities.

@endigma endigma requested a review from StarpTech as a code owner February 23, 2026 14:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 23, 2026

Walkthrough

Updated .github/CODEOWNERS with ownership entries for generated protobuf directories (/router/gen/, /connect-go/gen/, /graphqlmetrics/gen/, /connect/src/wg/) and minor formatting adjustments to existing entries.

Changes

Cohort / File(s) Summary
CODEOWNERS Configuration
.github/CODEOWNERS
Added ownership entries for four generated protobuf directories and adjusted formatting for existing /router/pkg/pubsub entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: excluding buf-generated protobuf files from CODEOWNERS requirements. It is concise, clear, and directly related to the primary modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/CODEOWNERS:
- Around line 32-36: The CODEOWNERS entries for the generated directories
(/router/gen/, /connect-go/gen/, /graphqlmetrics/gen/, /connect/src/wg/) are
invalid because they have no owners; remove these blank patterns or assign
explicit owner handles (e.g., `@org/team`) so GitHub recognizes them, or
alternatively remove the global "*" owner and explicitly list desired owned
paths excluding these generated directories and manage exclusions via GitHub
rulesets; update the .github/CODEOWNERS file by either deleting the four listed
lines or replacing each with a valid owner handle to resolve the invalid syntax.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 602e0ab and 2342214.

📒 Files selected for processing (1)
  • .github/CODEOWNERS

Comment thread .github/CODEOWNERS
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit f68841a into main Feb 23, 2026
9 checks passed
@StarpTech StarpTech deleted the jesse/no-generated-codeowners branch February 23, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants