Skip to content

fix(router): guard against nil context in getResponseHeaderPropagation #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stakeswky wants to merge 1 commit into from
Closed

fix(router): guard against nil context in getResponseHeaderPropagation #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions router/core/header_rule_engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ func WithResponseHeaderPropagation(ctx *resolve.Context) *resolve.Context {
}

func getResponseHeaderPropagation(ctx context.Context) *responseHeaderPropagation {
if ctx == nil {
return nil
}
v := ctx.Value(responseHeaderPropagationKey{})
if v == nil {
return nil
Expand Down
10 changes: 10 additions & 0 deletions router/core/header_rule_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,16 @@ func TestPropagatedHeaders(t *testing.T) {
})
}

func TestGetResponseHeaderPropagation_NilContext(t *testing.T) {
t.Parallel()

// Ensure nil context does not panic (regression test for #2530)
assert.NotPanics(t, func() {
result := getResponseHeaderPropagation(nil)
assert.Nil(t, result)
})
}

func TestNewHeaderPropagation(t *testing.T) {
t.Parallel()

Expand Down
Loading