Skip to content

fix: requires is not ignored when all fields provided#2498

Merged
devsergiy merged 1 commit intomainfrom
sergiy/eng-8899-requires-is-not-ignored-when-all-fields-provided
Feb 11, 2026
Merged

fix: requires is not ignored when all fields provided#2498
devsergiy merged 1 commit intomainfrom
sergiy/eng-8899-requires-is-not-ignored-when-all-fields-provided

Conversation

@devsergiy
Copy link
Copy Markdown
Member

@devsergiy devsergiy commented Feb 11, 2026

Summary by CodeRabbit

  • Chores
    • Updated core dependencies to latest compatible versions for improved stability and compatibility.

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 11, 2026

Walkthrough

This pull request updates Go module dependency versions across the router and router-tests packages. Updates include bumping graphql-go-tools/v2 from v2.0.0-rc.247 to v2.0.0-rc.248, cosmo/router, and cosmo/demo to more recent commits. These are version pin updates only.

Changes

Cohort / File(s) Summary
Go Module Dependency Updates
router/go.mod, router-tests/go.mod
Bumped graphql-go-tools/v2 from v2.0.0-rc.247 to v2.0.0-rc.248 across both files. Additionally updated cosmo/demo and cosmo/router to newer commit hashes in router-tests/go.mod.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'fix: requires is not ignored when all fields provided' does not align with the actual changes, which are purely dependency version bumps in go.mod files. The title suggests a bug fix related to field handling logic, but the changeset contains only version updates to cosmo/demo, cosmo/router, and graphql-go-tools. Update the title to accurately reflect the changes, such as 'chore: bump dependency versions in router and router-tests go.mod' or similar to match the actual dependency version updates in the changeset.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

❌ Internal Query Planner CI checks failed

The Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR.
If you are part of the WunderGraph organization, you can see the PR with more details.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.77%. Comparing base (4b780fe) to head (b3b269a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
+ Coverage   61.72%   61.77%   +0.05%     
==========================================
  Files         231      231              
  Lines       24154    24126      -28     
==========================================
- Hits        14909    14905       -4     
+ Misses       8002     7978      -24     
  Partials     1243     1243              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsergiy devsergiy merged commit 746b1e3 into main Feb 11, 2026
64 of 68 checks passed
@devsergiy devsergiy deleted the sergiy/eng-8899-requires-is-not-ignored-when-all-fields-provided branch February 11, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants