Skip to content

feat: add support for requires in protographic#2439

Merged
Noroth merged 76 commits into
mainfrom
ludwig/eng-8641-implement-proto-generation-in-protographic
Feb 26, 2026
Merged

feat: add support for requires in protographic#2439
Noroth merged 76 commits into
mainfrom
ludwig/eng-8641-implement-proto-generation-in-protographic

chore: resolve PR comments

bdec880
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 26, 2026 in 1s

43.84% (target 30.00%)

View this Pull Request on Codecov

43.84% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 89.59796% with 163 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.84%. Comparing base (cc360a6) to head (bdec880).

Files with missing lines Patch % Lines
protographic/src/abstract-selection-rewriter.ts 89.69% 37 Missing ⚠️
protographic/src/required-fields-visitor.ts 91.76% 27 Missing ⚠️
protographic/src/operations/message-builder.ts 18.75% 26 Missing ⚠️
protographic/src/sdl-to-proto-visitor.ts 92.80% 18 Missing ⚠️
...otographic/src/selection-set-validation-visitor.ts 84.11% 17 Missing ⚠️
protographic/src/sdl-validation-visitor.ts 90.21% 9 Missing ⚠️
protographic/src/sdl-to-mapping-visitor.ts 89.47% 8 Missing ⚠️
protographic/src/proto-lock.ts 70.58% 5 Missing ⚠️
protographic/src/operations/field-numbering.ts 55.55% 4 Missing ⚠️
...rotographic/src/operations/proto-text-generator.ts 81.81% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2439       +/-   ##
===========================================
- Coverage   62.28%   43.84%   -18.45%     
===========================================
  Files         242     1034      +792     
  Lines       25559   144938   +119379     
  Branches        0     9274     +9274     
===========================================
+ Hits        15919    63542    +47623     
- Misses       8300    79700    +71400     
- Partials     1340     1696      +356     
Files with missing lines Coverage Δ
protographic/src/index.ts 86.84% <100.00%> (ø)
protographic/src/operation-to-proto.ts 83.79% <100.00%> (ø)
protographic/src/operations/proto-field-options.ts 100.00% <100.00%> (ø)
protographic/src/operations/type-mapper.ts 88.74% <100.00%> (ø)
protographic/src/string-constants.ts 100.00% <100.00%> (ø)
protographic/src/types.ts 100.00% <100.00%> (ø)
router/gen/proto/wg/cosmo/node/v1/node.pb.go 20.62% <ø> (-0.26%) ⬇️
protographic/src/naming-conventions.ts 96.96% <93.10%> (ø)
protographic/src/proto-utils.ts 98.98% <98.98%> (ø)
protographic/src/operations/field-numbering.ts 83.78% <55.55%> (ø)
... and 10 more

... and 780 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.