Conversation
Contributor
WalkthroughBoth plan_generator.go and supervisor_instance.go swap the memory limit provider from FromCgroupHybrid to FromCgroup during GOMEMLIMIT auto-configuration. The logging behavior for success and failure cases remains unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
+ Coverage 60.75% 61.55% +0.79%
==========================================
Files 229 229
Lines 23818 23814 -4
==========================================
+ Hits 14470 14658 +188
+ Misses 8101 7919 -182
+ Partials 1247 1237 -10
🚀 New features to boost your workflow:
|
Noroth
approved these changes
Dec 18, 2025
dkorittki
pushed a commit
that referenced
this pull request
Dec 19, 2025
5 tasks
dbinnersley
added a commit
to dbinnersley/cosmo
that referenced
this pull request
Jan 5, 2026
…ueries (wundergraph#2411) chore(release): Publish [skip ci] - wgc@0.102.5 - @wundergraph/composition@0.49.0 - controlplane@0.181.0 - graphqlmetrics@0.37.0 - @wundergraph/protographic@0.14.0 - router@0.273.0 - @wundergraph/cosmo-shared@0.42.24 - studio@0.147.0 feat: upgrade NextJS (wundergraph#2410) chore(release): Publish [skip ci] - studio@0.148.0 fix: resolve js-yaml vulnerabilities (wundergraph#2415) feat: validate session cookie (wundergraph#2406) Co-authored-by: Milinda Dias <83293842+SkArchon@users.noreply.github.com> chore(release): Publish [skip ci] - wgc@0.102.6 - controlplane@0.182.0 - keycloak@0.11.1 fix: codecov carryforward paths are not detected (wundergraph#2412) chore: bumping expr dependency (wundergraph#2419) fix: make error accessible to custom modules (wundergraph#2420) chore(release): Publish [skip ci] - router@0.273.1 fix: use the correct cgroup policy to work on most of the systems (wundergraph#2421) chore(release): Publish [skip ci] - router@0.273.2 Add support for per message deflate to websocket connectinos Merge branch 'main' into per-message-deflate revert formatting
5 tasks
dbinnersley
added a commit
to dbinnersley/cosmo
that referenced
this pull request
Jan 5, 2026
…ueries (wundergraph#2411) chore(release): Publish [skip ci] - wgc@0.102.5 - @wundergraph/composition@0.49.0 - controlplane@0.181.0 - graphqlmetrics@0.37.0 - @wundergraph/protographic@0.14.0 - router@0.273.0 - @wundergraph/cosmo-shared@0.42.24 - studio@0.147.0 feat: upgrade NextJS (wundergraph#2410) chore(release): Publish [skip ci] - studio@0.148.0 fix: resolve js-yaml vulnerabilities (wundergraph#2415) feat: validate session cookie (wundergraph#2406) Co-authored-by: Milinda Dias <83293842+SkArchon@users.noreply.github.com> chore(release): Publish [skip ci] - wgc@0.102.6 - controlplane@0.182.0 - keycloak@0.11.1 fix: codecov carryforward paths are not detected (wundergraph#2412) chore: bumping expr dependency (wundergraph#2419) fix: make error accessible to custom modules (wundergraph#2420) chore(release): Publish [skip ci] - router@0.273.1 fix: use the correct cgroup policy to work on most of the systems (wundergraph#2421) chore(release): Publish [skip ci] - router@0.273.2 Add support for per message deflate to websocket connectinos Merge branch 'main' into per-message-deflate revert formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using a policy that supports cgroup v2 with hybrid layout and cgroups v1.
But systems that only supports pure cgroup v2 will not be correctly working.
So I changed it to use the FromCgroup that is checking for V2, V2 Hybrid and also V1 systems.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist