feat: update zod#2384
Conversation
WalkthroughRelaxed zod pins to caret ranges, removed several entries from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2384 +/- ##
=======================================
Coverage ? 32.61%
=======================================
Files ? 340
Lines ? 33837
Branches ? 251
=======================================
Hits ? 11035
Misses ? 21806
Partials ? 996 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
cli/package.json(1 hunks)package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
- GitHub Check: build_test
- GitHub Check: build_push_image
- GitHub Check: build_test
- GitHub Check: build_test
- GitHub Check: build_test
- GitHub Check: build_push_image
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
- GitHub Check: build_push_image
- GitHub Check: image_scan
- GitHub Check: build_test
- GitHub Check: build_push_image (nonroot)
- GitHub Check: integration_test (./events)
- GitHub Check: image_scan (nonroot)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
🔇 Additional comments (1)
package.json (1)
66-95: pnpm.overrides correctly kept in sync with direct dependency.The zod version (3.25.76) in pnpm.overrides matches the version in cli/package.json, ensuring all workspace packages use the same version uniformly. This override mechanism prevents version conflicts and non-deterministic hoisting across the monorepo, including packages that declare compatible caret ranges like controlplane and studio.
Dependency ReviewThe following issues were found:
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: build_push_image
- GitHub Check: build_push_image
- GitHub Check: build_push_image (nonroot)
- GitHub Check: image_scan (nonroot)
- GitHub Check: image_scan
- GitHub Check: integration_test (./events)
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: build_test
- GitHub Check: build_push_image
- GitHub Check: build_test
- GitHub Check: Analyze (go)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
package.json (1)
66-90: No action required — top-leveloverridesis valid in pnpm 9.12.3.pnpm supports both
pnpm.overrides(nested format) and the standard top-leveloverridesfield. Both are valid and are merged during dependency resolution, withpnpm.overridestaking precedence when both are present. The code's use of top-leveloverridesis correct and fully supported by pnpm 9.12.3.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
controlplane/emails/package.json (1)
21-21: Verify email build and dev scripts work with react-email 4.3.2.The version bump from 4.0.3 to 4.3.2 is a minor update within the same major version. Before merging, ensure the
devandbuildscripts execute without errors to confirm the email CLI and component exports function correctly with this version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
controlplane/emails/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
- GitHub Check: build-router
- GitHub Check: build_test
- GitHub Check: build_push_image
- GitHub Check: build_test
- GitHub Check: build_test
- GitHub Check: build_push_image (nonroot)
- GitHub Check: build_push_image
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: integration_test (./events)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: image_scan (nonroot)
- GitHub Check: build_test
- GitHub Check: image_scan
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: build_push_image
- GitHub Check: Analyze (go)
- GitHub Check: build_test
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
cli/package.json(2 hunks)controlplane/package.json(1 hunks)package.json(2 hunks)studio/package.json(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- controlplane/package.json
🚧 Files skipped from review as they are similar to previous changes (2)
- studio/package.json
- package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: build-router
- GitHub Check: image_scan (nonroot)
- GitHub Check: image_scan
- GitHub Check: build_push_image (nonroot)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: build_push_image
- GitHub Check: Analyze (go)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: build_test
- GitHub Check: build_test
- GitHub Check: build_test
- GitHub Check: build_push_image
- GitHub Check: build_push_image
- GitHub Check: build_test
🔇 Additional comments (1)
cli/package.json (1)
43-43: Dependency pin relaxed; verify lock file pins versions.Shifting
@bufbuild/protobuffrom exact pin to caret range (^1.9.0) is acceptable, but ensurepnpm-lock.yamllocks the resolved version to maintain reproducibility across installations and CI runs.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist
Initially, we believed that updating
zodto version3.25.76would resolve an issue encountered when runningbunx wgc, however, we ran into problems due to how we had setup dependencies, eventually we were able to resolve the dependency issue by removing the override for a few of the packages and undoing the version pinning forzodinstead of directly updating it