Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions router/pkg/pubsub/datasource/pubsubprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package datasource
import (
"context"
"fmt"
"slices"

"go.uber.org/zap"
"go.uber.org/zap/zapcore"
Expand Down Expand Up @@ -43,6 +44,10 @@ func (p *PubSubProvider) applyPublishEventHooks(ctx context.Context, cfg Publish
for _, hook := range p.hooks.OnPublishEvents {
var err error
currentEvents, err = hook(ctx, cfg, currentEvents, p.eventBuilder)
currentEvents = slices.DeleteFunc(currentEvents, func(event StreamEvent) bool {
return event == nil
})

if err != nil {
p.Logger.Error(
"error applying publish event hooks",
Expand Down
10 changes: 9 additions & 1 deletion router/pkg/pubsub/datasource/pubsubprovider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,17 @@ func TestProvider_Publish_WithHooks_Success(t *testing.T) {
}
originalEvents := []StreamEvent{
&testEvent{mutableTestEvent("original data")},
&testEvent{mutableTestEvent("original data 2")},
}
modifiedEvents := []StreamEvent{
&testEvent{mutableTestEvent("modified data")},
nil, // should be ignored by publisher
&testEvent{mutableTestEvent("modified data 2")},
nil, // should be ignored by publisher
}
expectedEvents := []StreamEvent{
&testEvent{mutableTestEvent("modified data")},
&testEvent{mutableTestEvent("modified data 2")},
}

var eventBuilderExists bool
Expand All @@ -240,7 +248,7 @@ func TestProvider_Publish_WithHooks_Success(t *testing.T) {
return modifiedEvents, nil
}

mockAdapter.On("Publish", mock.Anything, config, modifiedEvents).Return(nil)
mockAdapter.On("Publish", mock.Anything, config, expectedEvents).Return(nil)

provider := PubSubProvider{
Adapter: mockAdapter,
Expand Down
5 changes: 5 additions & 0 deletions router/pkg/pubsub/datasource/subscription_event_updater.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package datasource

import (
"context"
"slices"
"sync"

"github.com/wundergraph/graphql-go-tools/v2/pkg/engine/resolve"
Expand Down Expand Up @@ -86,6 +87,10 @@ func (s *subscriptionEventUpdater) updateSubscription(ctx context.Context, wg *s
var err error
for i := range hooks {
events, err = hooks[i](ctx, s.subscriptionEventConfiguration, s.eventBuilder, events)
events = slices.DeleteFunc(events, func(event StreamEvent) bool {
return event == nil
})

if err != nil {
errCh <- err
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ func TestSubscriptionEventUpdater_UpdateSubscription_WithHooks_Success(t *testin
}
modifiedEvents := []StreamEvent{
&testEvent{mutableTestEvent("modified data")},
nil, // this should simply be ignored
}

// Create wrapper function for the mock
Expand Down
Loading