Skip to content

feat: return additional linked check info when proposals are created/updated #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JivusAyrus merged 3 commits into from
Oct 6, 2025
Merged

feat: return additional linked check info when proposals are created/updated #2258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
004289d
feat: return additional linked check info when proposals are created/…
JivusAyrus Oct 2, 2025
f083af8
Merge branch 'main' into suvij/eng-8123-update-the-ui-of-check-on-the…
JivusAyrus Oct 3, 2025
2f65b96
Merge branch 'main' into suvij/eng-8123-update-the-ui-of-check-on-the…
JivusAyrus Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,338 changes: 1,682 additions & 1,656 deletions connect-go/gen/proto/wg/cosmo/platform/v1/platform.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions connect/src/wg/cosmo/platform/v1/platform_pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21616,6 +21616,11 @@ export class CreateProposalResponse extends Message<CreateProposalResponse> {
*/
isLinkedPruningCheckFailed?: boolean;

/**
* @generated from field: optional bool hasLinkedSchemaChecks = 20;
*/
hasLinkedSchemaChecks?: boolean;

constructor(data?: PartialMessage<CreateProposalResponse>) {
super();
proto3.util.initPartial(data, this);
Expand Down Expand Up @@ -21643,6 +21648,7 @@ export class CreateProposalResponse extends Message<CreateProposalResponse> {
{ no: 17, name: "proposalName", kind: "scalar", T: 9 /* ScalarType.STRING */ },
{ no: 18, name: "isLinkedTrafficCheckFailed", kind: "scalar", T: 8 /* ScalarType.BOOL */, opt: true },
{ no: 19, name: "isLinkedPruningCheckFailed", kind: "scalar", T: 8 /* ScalarType.BOOL */, opt: true },
{ no: 20, name: "hasLinkedSchemaChecks", kind: "scalar", T: 8 /* ScalarType.BOOL */, opt: true },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): CreateProposalResponse {
Expand Down Expand Up @@ -22210,6 +22216,11 @@ export class UpdateProposalResponse extends Message<UpdateProposalResponse> {
*/
isLinkedPruningCheckFailed?: boolean;

/**
* @generated from field: optional bool hasLinkedSchemaChecks = 17;
*/
hasLinkedSchemaChecks?: boolean;

constructor(data?: PartialMessage<UpdateProposalResponse>) {
super();
proto3.util.initPartial(data, this);
Expand All @@ -22234,6 +22245,7 @@ export class UpdateProposalResponse extends Message<UpdateProposalResponse> {
{ no: 14, name: "checkUrl", kind: "scalar", T: 9 /* ScalarType.STRING */ },
{ no: 15, name: "isLinkedTrafficCheckFailed", kind: "scalar", T: 8 /* ScalarType.BOOL */, opt: true },
{ no: 16, name: "isLinkedPruningCheckFailed", kind: "scalar", T: 8 /* ScalarType.BOOL */, opt: true },
{ no: 17, name: "hasLinkedSchemaChecks", kind: "scalar", T: 8 /* ScalarType.BOOL */, opt: true },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): UpdateProposalResponse {
Expand Down
2 changes: 2 additions & 0 deletions controlplane/src/core/bufservices/proposal/createProposal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ export function createProposal(
operationUsageStats,
isLinkedTrafficCheckFailed,
isLinkedPruningCheckFailed,
hasLinkedSchemaChecks,
} = await schemaCheckRepo.checkMultipleSchemas({
organizationId: authContext.organizationId,
organizationSlug: authContext.organizationSlug,
Expand Down Expand Up @@ -452,6 +453,7 @@ export function createProposal(
proposalName: proposal.name,
isLinkedTrafficCheckFailed,
isLinkedPruningCheckFailed,
hasLinkedSchemaChecks,
};
});
}
2 changes: 2 additions & 0 deletions controlplane/src/core/bufservices/proposal/updateProposal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ export function updateProposal(
operationUsageStats,
isLinkedTrafficCheckFailed,
isLinkedPruningCheckFailed,
hasLinkedSchemaChecks,
} = await schemaCheckRepo.checkMultipleSchemas({
organizationId: authContext.organizationId,
organizationSlug: authContext.organizationSlug,
Expand Down Expand Up @@ -493,6 +494,7 @@ export function updateProposal(
checkUrl: `${process.env.WEB_BASE_URL}/${authContext.organizationSlug}/${namespace.name}/graph/${federatedGraph.name}/checks/${checkId}`,
isLinkedPruningCheckFailed,
isLinkedTrafficCheckFailed,
hasLinkedSchemaChecks,
};
} else {
return {
Expand Down
1 change: 1 addition & 0 deletions controlplane/src/core/repositories/SchemaCheckRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,6 +1165,7 @@ export class SchemaCheckRepository {
proposalMatchMessage,
isLinkedTrafficCheckFailed,
isLinkedPruningCheckFailed,
hasLinkedSchemaChecks: linkedSubgraphs.length > 0,
};
}

Expand Down
2 changes: 2 additions & 0 deletions proto/wg/cosmo/platform/v1/platform.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2759,6 +2759,7 @@ message CreateProposalResponse {
optional bool isLinkedTrafficCheckFailed = 18;
// If true, it means the graph pruning check failed for the linked check
optional bool isLinkedPruningCheckFailed = 19;
optional bool hasLinkedSchemaChecks = 20;
}

message GetProposalRequest {
Expand Down Expand Up @@ -2837,6 +2838,7 @@ message UpdateProposalResponse {
optional bool isLinkedTrafficCheckFailed = 15;
// If true, it means the graph pruning check failed for the linked check
optional bool isLinkedPruningCheckFailed = 16;
optional bool hasLinkedSchemaChecks = 17;
}

message EnableProposalsForNamespaceRequest {
Expand Down
Loading