feat: allow to add a query-planner-skip label to ignore engine checks#2255
feat: allow to add a query-planner-skip label to ignore engine checks#2255
Conversation
WalkthroughRenames the CI gating job to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/query-planner-ci.yaml (1)
156-156: Fix the staleneedsreference to the renamed job.
check-label-and-engine-changesno longer exists, so the workflow will fail to even start. Update everyneedsentry that still uses the old id before merging.- needs: [ build-router, build-cli, cli-release-url, check-label-and-engine-changes ] + needs: [ build-router, build-cli, cli-release-url, check-labels-and-engine-changes ] ... - needs: [ build_test, check-label-and-engine-changes ] + needs: [ build_test, check-labels-and-engine-changes ]Also applies to: 179-179
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/query-planner-ci.yaml(9 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/query-planner-ci.yaml
55-55: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
126-126: input "with_tests" is not defined in action "Build and Push Image (PR only)" defined at "./.github/actions/build-push-image". available inputs are "docker_build_target", "docker_context", "docker_password", "docker_username", "dockerfile", "image_description", "image_name", "image_platforms", "load_Image", "push", "token"
(action)
162-162: property "check-labels-and-engine-changes" is not defined in object type {build-cli: {outputs: {wgc: string}; result: string}; build-router: {outputs: {image_ref: string}; result: string}; cli-release-url: {outputs: {wgc: string}; result: string}}
(expression)
162-162: property "check-labels-and-engine-changes" is not defined in object type {build-cli: {outputs: {wgc: string}; result: string}; build-router: {outputs: {image_ref: string}; result: string}; cli-release-url: {outputs: {wgc: string}; result: string}}
(expression)
162-162: property "check-labels-and-engine-changes" is not defined in object type {build-cli: {outputs: {wgc: string}; result: string}; build-router: {outputs: {image_ref: string}; result: string}; cli-release-url: {outputs: {wgc: string}; result: string}}
(expression)
181-181: property "check-labels-and-engine-changes" is not defined in object type {build_test: {outputs: {workflow_id: string; workflow_url: string}; result: string}}
(expression)
181-181: property "check-labels-and-engine-changes" is not defined in object type {build_test: {outputs: {workflow_id: string; workflow_url: string}; result: string}}
(expression)
181-181: property "check-labels-and-engine-changes" is not defined in object type {build_test: {outputs: {workflow_id: string; workflow_url: string}; result: string}}
(expression)
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Summary by CodeRabbit
Checklist