Skip to content

chore: testing query planner ci#2207

Closed
miklosbarabas wants to merge 37 commits intomainfrom
miklos/eng-8136-query-plan-tester-stuck
Closed

chore: testing query planner ci#2207
miklosbarabas wants to merge 37 commits intomainfrom
miklos/eng-8136-query-plan-tester-stuck

Conversation

@miklosbarabas
Copy link
Copy Markdown
Contributor

@miklosbarabas miklosbarabas commented Sep 11, 2025

Summary by CodeRabbit

  • Chores
    • CI configuration normalized (platform setting standardized; redundant test flag removed); no impact on product behavior.
  • Style
    • Non-functional comment added; no runtime or interface changes.
  • Notes
    • No user-facing changes in this release.

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 11, 2025

Walkthrough

Updated a CI workflow to quote a platform value and remove a test flag; added a non-functional comment and blank line to router/cmd/main.go. No behavioral, logic, or public API changes.

Changes

Cohort / File(s) Change summary
CI workflow
.github/workflows/query-planner-ci.yaml
Changed image_platforms value to a quoted string ('linux/amd64') and removed the with_tests: "false" line.
Router command
router/cmd/main.go
Inserted a non-functional comment immediately after the import block and added an extra blank line. No code, logic, or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely summarizes the main purpose of the changeset as a chore to test the query planner CI, follows Conventional Commits style, and is specific enough for teammates to understand the primary change at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a3bcdd and 1ef971f.

📒 Files selected for processing (2)
  • .github/workflows/query-planner-ci.yaml (1 hunks)
  • router/cmd/main.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/query-planner-ci.yaml
  • router/cmd/main.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-router
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: integration_test (./events)
  • GitHub Check: image_scan
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: build_test
  • GitHub Check: build_push_image
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 11, 2025

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-40dc10d636b7936cf405f557afa6fed9aa7d8842-nonroot

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/query-planner-ci.yaml (1)

151-159: Make the target ref configurable and add an explicit timeout to avoid stuck runs.

Pointing the CI trigger to a feature branch is fine for debugging, but it’s risky to merge as-is. Suggest parametrizing the ref with a repository variable and setting a timeout for the remote workflow wait.

Apply:

       with:
         owner: wundergraph
         repo: cosmo-celestial
-        ref: miklos/eng-8136-query-plan-tester-stuck
+        ref: ${{ vars.CELESTIAL_REF || 'master' }}
         github_token: ${{ secrets.GH_TOKEN_CELESTIAL_TRIGGER }}
         propagate_failure: true
+        workflow_timeout_seconds: 1800
         workflow_file_name: 'query-planner-tester.yaml'
router/cmd/main.go (1)

26-27: Remove stray test comment before merge.

Leftover noise in main entrypoint.

-// TEST COMMENT, REMOVE ME!
-
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2254925 and c7501b2.

📒 Files selected for processing (2)
  • .github/workflows/query-planner-ci.yaml (1 hunks)
  • router/cmd/main.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: build_push_image
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: build_test
  • GitHub Check: integration_test (./events)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: image_scan
  • GitHub Check: build-router
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/query-planner-ci.yaml (1)

151-159: Verify the target branch and workflow exist and are triggerable.

Automated check failed (gh: Not Found — HTTP 404); cannot verify. Before merging, confirm branch "miklos/eng-8136-query-plan-tester-stuck" exists in wundergraph/cosmo-celestial and that .github/workflows/query-planner-tester.yaml at that ref declares "workflow_dispatch" or "repository_dispatch".

@github-actions github-actions Bot added router and removed router labels Sep 11, 2025
@miklosbarabas miklosbarabas force-pushed the miklos/eng-8136-query-plan-tester-stuck branch from b61d421 to 4c4056f Compare September 15, 2025 08:41
@miklosbarabas miklosbarabas force-pushed the miklos/eng-8136-query-plan-tester-stuck branch from 0af83c6 to cb9831e Compare September 16, 2025 10:13
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9280817 and e7ee010.

📒 Files selected for processing (2)
  • .github/workflows/query-planner-ci.yaml (2 hunks)
  • router/cmd/main.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • router/cmd/main.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-router
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: build_push_image
  • GitHub Check: image_scan
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: integration_test (./events)
  • GitHub Check: build_test
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: integration_test (./telemetry)

Comment thread .github/workflows/query-planner-ci.yaml
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
router/cmd/main.go (1)

28-28: Remove workflow-trigger placeholder comment.

Let’s drop this temporary TODO so the entry point stays clean.

-// TODO: REMOVE ME! - TRIGGER WORKFLOW, REMOVE ME LATER! #GRRaagarrADsadBRRRRR23467565675YYYYYYXXXXX! "jobs fail with error code 143"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7ee010 and fa913df.

📒 Files selected for processing (1)
  • router/cmd/main.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-router
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: image_scan
  • GitHub Check: integration_test (./events)
  • GitHub Check: build_push_image
  • GitHub Check: build_test
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7528725 and d385d09.

📒 Files selected for processing (1)
  • router/cmd/main.go (1 hunks)

Comment thread router/cmd/main.go Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
router/cmd/main.go (1)

28-29: Drop the placeholder workflow comment.

This noisy TODO/comment was only meant for CI poking and doesn’t belong in the main entrypoint. Please remove it before merging.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76b3790 and 6a3bcdd.

📒 Files selected for processing (1)
  • router/cmd/main.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: build_test
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: build_push_image
  • GitHub Check: image_scan
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: integration_test (./events)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: Analyze (go)

@miklosbarabas
Copy link
Copy Markdown
Contributor Author

closing as not needed anymore for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants