chore: testing query planner ci#2207
Conversation
WalkthroughUpdated a CI workflow to quote a platform value and remove a test flag; added a non-functional comment and blank line to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/query-planner-ci.yaml (1)
151-159: Make the target ref configurable and add an explicit timeout to avoid stuck runs.Pointing the CI trigger to a feature branch is fine for debugging, but it’s risky to merge as-is. Suggest parametrizing the ref with a repository variable and setting a timeout for the remote workflow wait.
Apply:
with: owner: wundergraph repo: cosmo-celestial - ref: miklos/eng-8136-query-plan-tester-stuck + ref: ${{ vars.CELESTIAL_REF || 'master' }} github_token: ${{ secrets.GH_TOKEN_CELESTIAL_TRIGGER }} propagate_failure: true + workflow_timeout_seconds: 1800 workflow_file_name: 'query-planner-tester.yaml'router/cmd/main.go (1)
26-27: Remove stray test comment before merge.Leftover noise in main entrypoint.
-// TEST COMMENT, REMOVE ME! -
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/query-planner-ci.yaml(1 hunks)router/cmd/main.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: build_push_image (nonroot)
- GitHub Check: build_push_image
- GitHub Check: image_scan (nonroot)
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: build_test
- GitHub Check: integration_test (./events)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: image_scan
- GitHub Check: build-router
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/query-planner-ci.yaml (1)
151-159: Verify the target branch and workflow exist and are triggerable.Automated check failed (gh: Not Found — HTTP 404); cannot verify. Before merging, confirm branch "miklos/eng-8136-query-plan-tester-stuck" exists in wundergraph/cosmo-celestial and that .github/workflows/query-planner-tester.yaml at that ref declares "workflow_dispatch" or "repository_dispatch".
b61d421 to
4c4056f
Compare
0af83c6 to
cb9831e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/query-planner-ci.yaml(2 hunks)router/cmd/main.go(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- router/cmd/main.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: build-router
- GitHub Check: Analyze (go)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: build_push_image (nonroot)
- GitHub Check: build_push_image
- GitHub Check: image_scan
- GitHub Check: image_scan (nonroot)
- GitHub Check: integration_test (./events)
- GitHub Check: build_test
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: integration_test (./telemetry)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
router/cmd/main.go (1)
28-28: Remove workflow-trigger placeholder comment.Let’s drop this temporary TODO so the entry point stays clean.
-// TODO: REMOVE ME! - TRIGGER WORKFLOW, REMOVE ME LATER! #GRRaagarrADsadBRRRRR23467565675YYYYYYXXXXX! "jobs fail with error code 143"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
router/cmd/main.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: build-router
- GitHub Check: image_scan (nonroot)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: build_push_image (nonroot)
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: image_scan
- GitHub Check: integration_test (./events)
- GitHub Check: build_push_image
- GitHub Check: build_test
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
router/cmd/main.go (1)
28-29: Drop the placeholder workflow comment.This noisy TODO/comment was only meant for CI poking and doesn’t belong in the main entrypoint. Please remove it before merging.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
router/cmd/main.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: build_test
- GitHub Check: build_push_image (nonroot)
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: build_push_image
- GitHub Check: image_scan
- GitHub Check: image_scan (nonroot)
- GitHub Check: integration_test (./events)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: Analyze (go)
|
closing as not needed anymore for testing |
Summary by CodeRabbit
Checklist