Skip to content

chore: update bitnami image refs#2171

Merged
Noroth merged 2 commits intomainfrom
ludwig/eng-7942-update-images-in-cosmo
Aug 28, 2025
Merged

chore: update bitnami image refs#2171
Noroth merged 2 commits intomainfrom
ludwig/eng-7942-update-images-in-cosmo

Conversation

@Noroth
Copy link
Copy Markdown
Contributor

@Noroth Noroth commented Aug 27, 2025

Due to upcoming changes to the bitnami registry we need to update the image refs

Summary by CodeRabbit

  • Chores

    • Switched Keycloak, Kafka, and MinIO containers to legacy images for improved stability and compatibility across environments.
    • Aligned local and full-stack deployments to use the updated images without configuration changes.
  • Tests

    • Updated integration test environment to use the legacy Kafka image for parity with runtime.

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 27, 2025

Walkthrough

Container images were switched from bitnami to bitnamilegacy across CI and deployment configs: Kafka and MinIO images updated in docker-compose files; Kafka image updated in the GitHub Actions workflow; and the Keycloak Dockerfile base image changed accordingly. No other configuration or logic changes were made.

Changes

Cohort / File(s) Summary of changes
Compose and CI image switches (Kafka, MinIO)
docker-compose.yml, docker-compose.full.yml, .github/workflows/router-ci.yaml
Replaced Bitnami images with BitnamiLegacy: Kafka bitnami/kafka:3.7.0bitnamilegacy/kafka:3.7.0 in all three files; MinIO bitnami/minio:${DC_MINIO_VERSION:-2024.7.16-debian-12-r0}bitnamilegacy/minio:${DC_MINIO_VERSION:-2024.7.16-debian-12-r0} in both compose files. Other settings unchanged.
Keycloak base image update
keycloak/Dockerfile
FROM image changed: bitnami/keycloak:25.0.2bitnamilegacy/keycloak:25.0.2. No other Dockerfile modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ludwig/eng-7942-update-images-in-cosmo

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 27, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-34eeaa0af1c8f1dce90aac074a0f83d76ed10ee7

@Noroth Noroth marked this pull request as ready for review August 28, 2025 07:59
@Noroth Noroth requested a review from ysmolski August 28, 2025 07:59
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docker-compose.full.yml (1)

175-175: Full compose aligns with bitnamilegacy; mirror health checks and ensure MinIO path.

  • Kafka here lacks a healthcheck while the dev compose has one; consider adding for parity to improve local readiness checks.
  • Confirm MinIO keeps /bitnami/minio/data under the legacy image.

Apply if you want parity with dev compose:

   kafka:
     image: bitnamilegacy/kafka:3.7.0
+    healthcheck:
+      test: ['CMD-SHELL', 'kafka-broker-api-versions.sh --version']
+      interval: 10s
+      timeout: 5s
+      retries: 5

Also applies to: 205-205

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0383f and 05a70d8.

📒 Files selected for processing (4)
  • .github/workflows/router-ci.yaml (1 hunks)
  • docker-compose.full.yml (2 hunks)
  • docker-compose.yml (2 hunks)
  • keycloak/Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
🔇 Additional comments (2)
keycloak/Dockerfile (1)

15-15: Verify provider path and kc.sh build flags

  • Run docker run --rm bitnamilegacy/keycloak:25.0.2 ls -d /opt/bitnami/keycloak/providers to confirm the providers directory exists.
  • Run or inspect docker run --rm bitnamilegacy/keycloak:25.0.2 /opt/bitnami/keycloak/bin/kc.sh build --db=postgres --metrics-enabled true --health-enabled true --http-relative-path "/" (or check kc.sh --help) to ensure all required build flags are supported.
  • Ensure these match your Helm chart/docker-compose settings to avoid startup drift.
docker-compose.yml (1)

168-168: Validate bitnamilegacy image tags & clean up stale bitnami references

  • Confirmed that bitnamilegacy/minio:2024.7.16-debian-12-r0, bitnamilegacy/kafka:3.7.0 and bitnamilegacy/keycloak:25.0.2 are published and pullable.
  • Repository still contains bitnami/… mounts and paths:
    • docker-compose.yml (lines 40, 177)
    • docker-compose.full.yml (lines 165, 184)
    • keycloak/Dockerfile (COPY path, build script)
    • helm/cosmo/values.yaml (lines 346, 385, 461) and README.md (line 182)
    Update these to match bitnamilegacy image semantics (volume mounts, import dirs, KRaft envs).
  • Pin CI-critical images by digest to guard against upstream tag drift.

Comment thread .github/workflows/router-ci.yaml
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noroth Noroth merged commit 1fe521e into main Aug 28, 2025
47 of 49 checks passed
@Noroth Noroth deleted the ludwig/eng-7942-update-images-in-cosmo branch August 28, 2025 08:17
@Noroth Noroth mentioned this pull request Sep 30, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants