Skip to content

fix: add tracing by default and fix bugs #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkArchon merged 2 commits into from
Aug 25, 2025
Merged

fix: add tracing by default and fix bugs #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48fa40e
feat: fix plugin bugs
SkArchon Aug 25, 2025
f35cac5
fix: linting
SkArchon Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cli/src/commands/router/commands/plugin/commands/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ export default (opts: BaseCommandOptions) => {
const cwd = process.cwd();

const projectDir = resolve(cwd, options.directory, options.project);
const pluginDir = resolve(cwd, projectDir, name);

const pluginDir = options.project ? resolve(cwd, projectDir, 'plugins', name) : resolve(cwd, projectDir, name);

const originalPluginName = name;

name = upperFirst(camelCase(name));
Expand Down Expand Up @@ -97,6 +99,7 @@ export default (opts: BaseCommandOptions) => {

// Create a project directory structure
await mkdir(projectDir, { recursive: true });
await mkdir(resolve(projectDir, 'plugins'), { recursive: true });

// Write router config to the project root
await writeFile(resolve(projectDir, 'config.yaml'), ProjectTemplates.routerConfig);
Expand Down
4 changes: 2 additions & 2 deletions cli/src/commands/router/commands/plugin/templates/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ go 1.24.1

require (
github.com/stretchr/testify v1.10.0
github.com/wundergraph/cosmo/router-plugin v0.0.0-20250519204649-84818397f974 // v0.1.0
github.com/wundergraph/cosmo/router-plugin v0.0.0-20250824152218-8eebc34c4995 // v0.4.1
google.golang.org/grpc v1.68.1
google.golang.org/protobuf v1.36.5
)
Expand Down Expand Up @@ -55,7 +55,7 @@ func main() {
s.RegisterService(&service.{serviceName}_ServiceDesc, &{serviceName}{
nextID: 1,
})
})
}, routerplugin.WithTracing())

if err != nil {
log.Fatalf("failed to create router plugin: %v", err)
Expand Down