fix: skip hardcoded propagation

[SkArchon]

Right now we have a hardcoded propagation, which means that methods such as jaeger are innefective in the plugin.

Summary by CodeRabbit

• Refactor
  • Enhanced tracing header extraction to include all metadata keys with values, improving the completeness of tracing information propagation.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
• I have read the Contributors Guide.

[coderabbitai]

Warning

Rate limit exceeded

@SkArchon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between dc4b6f7 and 5a82f77.

📒 Files selected for processing (3)

• .github/workflows/router-ci.yaml (1 hunks)
• router-plugin/tracing/interceptor.go (1 hunks)
• router/pkg/grpcconnector/grpc_plugin.go (1 hunks)

Walkthrough

The logic for extracting tracing headers from gRPC metadata in the tracing interceptor was changed. Instead of selectively copying only specific tracing headers, the code now iterates through all metadata keys and copies their first value into the propagation carrier. No exported or public entity declarations were modified.

Changes

Cohort / File(s)	Change Summary
Tracing Metadata Extraction Update router-plugin/tracing/interceptor.go	Changed tracing header extraction from selective (specific keys) to comprehensive (all metadata keys and their first value).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch milinda/tracing-fix-propagation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

router-plugin/tracing/interceptor.go (1)

15-19: Clean up unused constants.

The header name constants are no longer used after switching to the generic metadata extraction approach. Consider removing them to keep the code clean.

-const (
-	traceparentHeader = "traceparent"
-	tracestateHeader  = "tracestate"
-	baggageHeader     = "baggage"
-)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74bcaa7 and 2739575.

📒 Files selected for processing (1)

• router-plugin/tracing/interceptor.go (1 hunks)

🔇 Additional comments (1)

router-plugin/tracing/interceptor.go (1)

37-41: LGTM! This change properly addresses the hardcoded propagation issue.

The switch from hardcoded header extraction to iterating through all metadata keys is exactly what's needed to fix the Jaeger tracing issue mentioned in the PR objectives. This approach allows any tracing propagation headers to be passed through, not just the predefined ones.

[github-actions]

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-dc8a1211274d7a925a1560bbc9c5dc4d5b2ac029-nonroot