fix: use input file location for compose

[Noroth]

Summary by CodeRabbit

• Bug Fixes
  • Improved file path resolution for subgraph metadata processing and validation, ensuring files are correctly located relative to the input file location for GRPC and plugin subgraphs. This enhances reliability when working with files in different directories.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
• I have read the Contributors Guide.

[endigma]

lgtm with a nit on repetition of calls to resolve

[coderabbitai]

Walkthrough

This change updates several functions related to subgraph metadata processing and validation to accept an additional inputFileLocation parameter. This parameter is used to resolve file paths relative to the input file location for GRPC and plugin subgraphs. All relevant function signatures and their internal file path resolutions have been modified accordingly.

Changes

Cohort / File(s)	Change Summary
Subgraph Metadata Path Resolution cli/src/commands/router/commands/compose.ts	Added inputFileLocation parameter to subgraph metadata and validation functions for GRPC and plugin subgraphs. Updated file and directory path resolutions to be relative to inputFileLocation. Adjusted function signatures and call sites.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a947b1 and 875bdf3.

📒 Files selected for processing (1)

• cli/src/commands/router/commands/compose.ts (7 hunks)

🔇 Additional comments (4)

cli/src/commands/router/commands/compose.ts (4)

273-288: LGTM! Function signature and calls updated correctly.

The function now properly accepts and propagates the inputFileLocation parameter to the specialized metadata functions that need it for relative path resolution.

---

290-307: LGTM! File path resolution now works correctly.

The function properly uses inputFileLocation to resolve all file paths relative to the configuration file location, which fixes the core issue described in the PR.

---

309-341: LGTM! Plugin file resolution implemented correctly.

The function now resolves plugin-related file paths (mapping.json, schema.graphql, service.proto) relative to the input file location, ensuring consistent behavior with other subgraph types.

---

469-499: LGTM! Plugin path validation updated correctly.

The function now validates plugin path existence relative to the input file location, maintaining consistency with the GRPC validation function.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ludwig/fix-file-location-for-compose

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.