fix: impose limit on origin length when CORS is enabled with a wildcard

[endigma]

segment

Summary by CodeRabbit

• New Features

  • Improved wildcard matching for CORS origins, supporting more flexible and efficient pattern handling.
  • Introduced a limit on the length of origin strings eligible for wildcard matching to enhance security and performance.

• Bug Fixes

  • Enhanced validation logic to ensure correct handling of extreme-length origins and strict origins.

• Tests

  • Added comprehensive tests for wildcard pattern matching and length-based validation.
  • Improved benchmark tests to cover various wildcard and strict origin scenarios.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
• I have read the Contributors Guide.

[coderabbitai]

Warning

Rate limit exceeded

@endigma has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a1fa0be and 7a7603a.

📒 Files selected for processing (1)

• router/pkg/cors/config.go (5 hunks)

Walkthrough

The changes introduce a new WildcardPattern type for more efficient and maintainable wildcard origin matching in the CORS package. The CORS configuration and validation logic are refactored to use this new type, with stricter length checks and improved test coverage. Benchmarking and test cases are updated and expanded accordingly.

Changes

Cohort / File(s)	Change Summary
CORS Wildcard Matching Implementation router/pkg/cors/wildcard.go	Introduces the WildcardPattern type and supporting logic for compiling and matching wildcard patterns efficiently, replacing prior recursive matching.
Wildcard Pattern Unit Tests router/pkg/cors/wildcard_test.go	Adds comprehensive tests for wildcard pattern compilation, normalization, and matching, including edge cases and byte/string input variations.
CORS Core Logic Refactor router/pkg/cors/config.go	Refactors the CORS struct and logic to use WildcardPattern for wildcard origin matching, adds a length limit for origins, simplifies validation, and optimizes header copying.
Wildcard Rule Parsing Refactor router/pkg/cors/cors.go	Replaces manual wildcard rule parsing with a new method that compiles patterns using WildcardPattern, updating the return type and logic accordingly.
CORS Tests and Benchmarks Update router/pkg/cors/cors_test.go	Adds new tests for extreme origin length and disables recursion-depth tests. Refactors and expands benchmarks to cover various wildcard and non-wildcard scenarios. Improves assertion diagnostics.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~18 minutes

• The review involves understanding a new pattern matching implementation, its integration into the CORS logic, and comprehensive test and benchmark updates. The changes are localized but non-trivial, requiring attention to correctness and performance.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jesse/eng-7657-cors-subdomain-recursion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-17e8f8be973d4bc6653567587cde2c95221b4922

[github-actions]

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-54d961595f83c42bbc40a14d118a09c099cd7032

[StarpTech]

Please add a simple unit test.

[StarpTech]

LGTM

[StarpTech]

LGTM