Skip to content

fix(router): record operation planning time correctly in plan error case #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
endigma merged 2 commits into from
Aug 15, 2025
Merged

fix(router): record operation planning time correctly in plan error case #2070

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4584bc
Add log when planning time exceeds threshhold
endigma Jul 22, 2025
9f6c4a0
Remove planning time log warning
endigma Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions router/core/graphql_prehandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,7 @@ func (h *PreHandler) handleOperation(req *http.Request, variablesParser *astjson
if !requestContext.operation.traceOptions.ExcludePlannerStats {
httpOperation.traceTimings.StartPlanning()
}

startPlanning := time.Now()

_, enginePlanSpan := h.tracer.Start(req.Context(), "Operation - Plan",
Expand All @@ -984,22 +985,26 @@ func (h *PreHandler) handleOperation(req *http.Request, variablesParser *astjson
err = h.planner.plan(requestContext.operation, planOptions)
if err != nil {
httpOperation.requestLogger.Debug("failed to plan operation", zap.Error(err))
rtrace.AttachErrToSpan(enginePlanSpan, err)

if !requestContext.operation.traceOptions.ExcludePlannerStats {
httpOperation.traceTimings.EndPlanning()
}

requestContext.operation.planningTime = time.Since(startPlanning)

rtrace.AttachErrToSpan(enginePlanSpan, err)
enginePlanSpan.End()

return err
}

enginePlanSpan.SetAttributes(otel.WgEnginePlanCacheHit.Bool(requestContext.operation.planCacheHit))
if !requestContext.operation.traceOptions.ExcludePlannerStats {
httpOperation.traceTimings.EndPlanning()
}

requestContext.operation.planningTime = time.Since(startPlanning)
httpOperation.traceTimings.EndPlanning()

enginePlanSpan.SetAttributes(otel.WgEnginePlanCacheHit.Bool(requestContext.operation.planCacheHit))
enginePlanSpan.End()

planningAttrs := *requestContext.telemetry.AcquireAttributes()
Expand Down
Loading