fix: `log_level` config schema to align with parse behaviour by endigma · Pull Request #2025 · wundergraph/cosmo

endigma · 2025-07-08T12:22:18Z

Summary by CodeRabbit

Chores
- Updated log level options in configuration to replace "warning" with "warn" and reordered levels.
- Improved log level parsing using standard library methods.
- Added tests to verify correct handling of all supported log levels.

Checklist

I have discussed my proposed changes in an issue and have received approval to proceed.
I have followed the coding standards of the project.
Tests or benchmarks have been added or updated.
Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
I have read the Contributors Guide.

coderabbitai · 2025-07-08T12:22:25Z

Walkthrough

The change updates the enumeration values for the "log_level" property in the JSON schema configuration, replacing "warning" with "warn" and reordering the log levels. It removes a custom log level parsing function, replacing its usage with zapcore.ParseLevel. A new test function was added to verify correct parsing of all supported log levels in configuration files.

Changes

File	Change Summary
router/pkg/config/config.schema.json	Updated "log_level" enum: replaced "warning" with "warn" and reordered values.
router/pkg/config/config_test.go	Added `TestLogLevels` to verify parsing of supported log levels; updated imports accordingly.
router/cmd/plan_generator.go	Replaced custom log level parsing with `zapcore.ParseLevel`; updated allowed log level flag description.
router/pkg/logging/logging.go	Removed `ZapLogLevelFromString` function and related imports (`fmt`, `strings`).

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60b6c5e and 6af32e2.

📒 Files selected for processing (4)

router/cmd/plan_generator.go (3 hunks)
router/pkg/config/config.schema.json (1 hunks)
router/pkg/config/config_test.go (2 hunks)
router/pkg/logging/logging.go (0 hunks)

💤 Files with no reviewable changes (1)

router/pkg/logging/logging.go

🚧 Files skipped from review as they are similar to previous changes (3)

router/cmd/plan_generator.go
router/pkg/config/config_test.go
router/pkg/config/config.schema.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: build-router
GitHub Check: integration_test (./events)
GitHub Check: build_push_image
GitHub Check: integration_test (./telemetry)
GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
GitHub Check: build_test
GitHub Check: image_scan
GitHub Check: Analyze (go)
GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

router/pkg/config/config.schema.json (1)

1348-1352: Schema aligns with runtime parser but could break existing configs – highlight in docs / release notes

Switching from "warning" → "warn" (and adding "dpanic") correctly mirrors the zap log-level parser, so the validation/runtime gap is closed.
However, any user that previously relied on "warning" will now fail schema validation instead of merely getting an unexpected runtime level.

Action items:

Update user-facing docs and configuration examples to reflect the new values.

Mention the breaking-change nature in the CHANGELOG / release notes so integrators can migrate.

No code change needed here; just ensuring rollout awareness.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e753dce and cc1b3d8.

📒 Files selected for processing (1)

router/pkg/config/config.schema.json (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

router/pkg/config/config.schema.json (1)

undefined

<retrieved_learning>
Learnt from: endigma
PR: #2009
File: router/pkg/config/config.go:0-0
Timestamp: 2025-07-03T10:33:25.778Z
Learning: The CardinalityLimit field in the Metrics struct (router/pkg/config/config.go) is validated at the JSON schema level in config.schema.json with a minimum value constraint of 1, preventing zero or negative values without requiring runtime validation.
</retrieved_learning>

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: build-router
GitHub Check: build_push_image
GitHub Check: build_test
GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
GitHub Check: image_scan
GitHub Check: Analyze (javascript-typescript)
GitHub Check: Analyze (go)

github-actions · 2025-07-08T12:24:37Z

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-3d72413b7c162f81bf626415c5cccb2b191e7da9

Aenimus

LGTM!

StarpTech

LGTM

StarpTech · 2025-07-09T07:35:32Z

I think ne never exposed dpanic, we need to update the docs.

log levels in plan_generator to match router

…raph#2025)

endigma requested review from Noroth, StarpTech and devsergiy as code owners July 8, 2025 12:22

github-actions Bot added the router label Jul 8, 2025

coderabbitai Bot reviewed Jul 8, 2025

View reviewed changes

Aenimus approved these changes Jul 8, 2025

View reviewed changes

Noroth approved these changes Jul 8, 2025

View reviewed changes

StarpTech approved these changes Jul 9, 2025

View reviewed changes

endigma added 4 commits July 9, 2025 09:30

fix: log_level config schema to align with parse behaviour

fadd151

Add unit test for parsing all log levels

38f70d9

chore: remove ZapLogLevelFromString function from pkg/logging, update

4c71462

log levels in plan_generator to match router

chore: remove dpanic level from schema for now

6af32e2

endigma force-pushed the jesse/fix-log-level-schema branch from 7b24c40 to 6af32e2 Compare July 9, 2025 08:30

endigma mentioned this pull request Jul 9, 2025

Update log level docs with allowed levels wundergraph/cosmo-docs#118

Merged

endigma merged commit 12e2b9e into main Jul 9, 2025
31 of 32 checks passed

endigma deleted the jesse/fix-log-level-schema branch July 9, 2025 09:38

coderabbitai Bot mentioned this pull request Jul 9, 2025

fix: update plan generator default log level to warn from warning #2029

Merged

5 tasks

yuzoonc1 pushed a commit to yuzoonc1/cosmo that referenced this pull request Jul 9, 2025

fix: log_level config schema to align with parse behaviour (wunderg…

0d79eff

…raph#2025)

coderabbitai Bot mentioned this pull request Oct 8, 2025

fix: improve access logs #2266

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `log_level` config schema to align with parse behaviour#2025

fix: `log_level` config schema to align with parse behaviour#2025
endigma merged 4 commits intomainfrom
jesse/fix-log-level-schema

endigma commented Jul 8, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 8, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

github-actions Bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

Aenimus left a comment

Uh oh!

StarpTech left a comment

Uh oh!

StarpTech commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

endigma commented Jul 8, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

coderabbitai Bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Router image scan passed

Uh oh!

Aenimus left a comment

Choose a reason for hiding this comment

Uh oh!

StarpTech left a comment

Choose a reason for hiding this comment

Uh oh!

StarpTech commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

endigma commented Jul 8, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Jul 8, 2025 •

edited

Loading