Skip to content

fix: astparser/lexer fixes#2020

Merged
devsergiy merged 1 commit intomainfrom
fix/ENG-7491-ast-fixes
Jul 7, 2025
Merged

fix: astparser/lexer fixes#2020
devsergiy merged 1 commit intomainfrom
fix/ENG-7491-ast-fixes

Conversation

@devsergiy
Copy link
Copy Markdown
Member

@devsergiy devsergiy commented Jul 7, 2025

fixes ENG-5055
fixes ENG-5916
fixes ENG-7491
fixes ENG-7072

2.0.0-rc.199 (2025-07-07)

Features

Bug Fixes

  • do not trim whitespaces around non-block strings, normalization fix (#1211) (6f5046b)

Checklist

Summary by CodeRabbit

  • Chores
    • Updated underlying dependencies to improve stability and compatibility. No user-facing changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 7, 2025

Walkthrough

The dependency versions for the module github.com/wundergraph/graphql-go-tools/v2 were updated from rc.198 to rc.199 in both router/go.mod and router-tests/go.mod. Additionally, two other dependencies in router-tests/go.mod were upgraded to newer commit hashes.

Changes

Files Change Summary
router/go.mod, router-tests/go.mod Updated github.com/wundergraph/graphql-go-tools/v2 from rc.198 to rc.199.
router-tests/go.mod Upgraded github.com/wundergraph/cosmo/demo and github.com/wundergraph/cosmo/router to newer commit hashes.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added the router label Jul 7, 2025
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-172d810a903a72ce33c5a0ef68e3051b72cbcd7f

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
router-tests/go.mod (1)

25-28: Rationalise require vs replace for local modules

cosmo/demo and cosmo/router were bumped to commit 35d60cac85d9, yet they are immediately overridden by replace lines that point to local paths.
The commit hash in require is therefore ignored during builds and may confuse future maintainers.

Consider either:

-	github.com/wundergraph/cosmo/demo v0.0.0-20250707145555-35d60cac85d9
-	github.com/wundergraph/cosmo/router v0.0.0-20250707145555-35d60cac85d9
+	// (requirements removed – local paths via replace)

or drop the replace directives and rely purely on the version pin, whichever matches your workflow.

This also keeps go mod tidy output stable across contributors who don’t have the repo checked out in the same filesystem layout.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35d60ca and ffcfe11.

⛔ Files ignored due to path filters (2)
  • router-tests/go.sum is excluded by !**/*.sum
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • router-tests/go.mod (1 hunks)
  • router/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: build-router
  • GitHub Check: build_push_image
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: integration_test (./events)
  • GitHub Check: image_scan
  • GitHub Check: build_test
  • GitHub Check: Analyze (go)
  • GitHub Check: build_test
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
router/go.mod (1)

34-34: Confirm rc.199 bump is fully propagated & run go mod tidy

Upgrading github.com/wundergraph/graphql-go-tools/v2 to v2.0.0-rc.199 is fine, but please make sure:

  1. go mod tidy has been executed so that go.sum reflects the new checksums and any now-unused transitive modules are pruned.
  2. All packages still compile & unit/integration tests pass against the new release; the parser/lexer work touched by ENG-5055/5916/7491/7072 depends heavily on that lib.

If CI already covers this, feel free to ignore.

router-tests/go.mod (1)

28-28: Ensure test workspace uses the same rc.199 artefacts

The bump to github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.199 mirrors the router module – good for consistency.
Just double-check that:

  • No test helpers import rc.198 via indirect deps (run go mod tidy && go list -m all | grep graphql-go-tools to confirm).
  • Snapshot data (e.g., Goldie fixtures) is still valid if the normalisation fix (issue #1211) changes whitespace handling.

@devsergiy devsergiy merged commit 08a7037 into main Jul 7, 2025
26 checks passed
@devsergiy devsergiy deleted the fix/ENG-7491-ast-fixes branch July 7, 2025 15:59
yuzoonc1 pushed a commit to yuzoonc1/cosmo that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants