Conversation
WalkthroughThe dependency versions for the module Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Router image scan passed✅ No security vulnerabilities found in image: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
router-tests/go.mod (1)
25-28: Rationaliserequirevsreplacefor local modules
cosmo/demoandcosmo/routerwere bumped to commit35d60cac85d9, yet they are immediately overridden byreplacelines that point to local paths.
The commit hash inrequireis therefore ignored during builds and may confuse future maintainers.Consider either:
- github.com/wundergraph/cosmo/demo v0.0.0-20250707145555-35d60cac85d9 - github.com/wundergraph/cosmo/router v0.0.0-20250707145555-35d60cac85d9 + // (requirements removed – local paths via replace)or drop the
replacedirectives and rely purely on the version pin, whichever matches your workflow.This also keeps
go mod tidyoutput stable across contributors who don’t have the repo checked out in the same filesystem layout.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
router-tests/go.sumis excluded by!**/*.sumrouter/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
router-tests/go.mod(1 hunks)router/go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: build-router
- GitHub Check: build_push_image
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: integration_test (./events)
- GitHub Check: image_scan
- GitHub Check: build_test
- GitHub Check: Analyze (go)
- GitHub Check: build_test
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
router/go.mod (1)
34-34: Confirm rc.199 bump is fully propagated & rungo mod tidyUpgrading
github.com/wundergraph/graphql-go-tools/v2tov2.0.0-rc.199is fine, but please make sure:
go mod tidyhas been executed so thatgo.sumreflects the new checksums and any now-unused transitive modules are pruned.- All packages still compile & unit/integration tests pass against the new release; the parser/lexer work touched by ENG-5055/5916/7491/7072 depends heavily on that lib.
If CI already covers this, feel free to ignore.
router-tests/go.mod (1)
28-28: Ensure test workspace uses the same rc.199 artefactsThe bump to
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.199mirrors the router module – good for consistency.
Just double-check that:
- No test helpers import
rc.198via indirect deps (rungo mod tidy && go list -m all | grep graphql-go-toolsto confirm).- Snapshot data (e.g., Goldie fixtures) is still valid if the normalisation fix (issue #1211) changes whitespace handling.
fixes ENG-5055
fixes ENG-5916
fixes ENG-7491
fixes ENG-7072
2.0.0-rc.199 (2025-07-07)
Features
Bug Fixes
Checklist
Summary by CodeRabbit