Skip to content

fix: fix collecting representation for fetches scoped to concrete types#2017

Merged
devsergiy merged 1 commit intomainfrom
sergiy/eng-7460-fix-unnecessary-fetch-from-a-subgraph
Jul 4, 2025
Merged

fix: fix collecting representation for fetches scoped to concrete types#2017
devsergiy merged 1 commit intomainfrom
sergiy/eng-7460-fix-unnecessary-fetch-from-a-subgraph

Conversation

@devsergiy
Copy link
Copy Markdown
Member

@devsergiy devsergiy commented Jul 4, 2025

Update engine to 2.0.0-rc.198 (2025-07-04)

Features

Bug Fixes

  • fix collecting representation for fetches scoped to concrete types (#1200) (bcf547d)

Summary by CodeRabbit

  • Chores
    • Updated several dependencies to their latest versions for improved stability and compatibility.

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 4, 2025

Walkthrough

The updates modify the go.mod files in both the router-tests and router modules. Dependency versions were bumped: github.com/wundergraph/graphql-go-tools/v2 was updated in both modules, while github.com/wundergraph/cosmo/demo and github.com/wundergraph/cosmo/router were updated in router-tests. No other changes were made.

Changes

Files Change Summary
router-tests/go.mod Updated github.com/wundergraph/cosmo/demo and github.com/wundergraph/cosmo/router to newer commits; upgraded github.com/wundergraph/graphql-go-tools/v2 from rc.197 to rc.198.
router/go.mod Upgraded github.com/wundergraph/graphql-go-tools/v2 from rc.197 to rc.198.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d119b9 and d5c4b82.

⛔ Files ignored due to path filters (2)
  • router-tests/go.sum is excluded by !**/*.sum
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • router-tests/go.mod (1 hunks)
  • router/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: build-router
  • GitHub Check: build_test
  • GitHub Check: integration_test (./events)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: build_push_image
  • GitHub Check: build_test
  • GitHub Check: image_scan
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
router/go.mod (1)

34-35: graphql-go-tools version bump is shadowed by active replace directive

Line 164 (unchanged) still contains

replace github.com/wundergraph/graphql-go-tools/v2 => ../../graphql-go-tools/v2

Because an active replace overrides the version selected in require, the new v2.0.0-rc.198 constraint on line 34 is effectively ignored for this module.
Make sure the local path checked out at ../../graphql-go-tools/v2 is updated to the same rc.198 commit, or drop the replace before merging to avoid divergent versions between router and other modules (e.g. router-tests).

router-tests/go.mod (1)

25-28: Cross-module dependency consistency verified
After running go mod tidy in router-tests and listing all module versions, only github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.198 appears—no older versions are pulled in indirectly.
No further action required.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@devsergiy devsergiy changed the title fix: collecting representation for fetches scoped to concrete types fix: fix collecting representation for fetches scoped to concrete types Jul 4, 2025
@github-actions github-actions Bot added the router label Jul 4, 2025
Copy link
Copy Markdown
Member

@Aenimus Aenimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-434747ffd67553e185ef47557503f7dbf2d196de

Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsergiy devsergiy merged commit bc9bb36 into main Jul 4, 2025
33 of 34 checks passed
@devsergiy devsergiy deleted the sergiy/eng-7460-fix-unnecessary-fetch-from-a-subgraph branch July 4, 2025 15:40
yuzoonc1 pushed a commit to yuzoonc1/cosmo that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants