Merged
Conversation
Router image scan passed✅ No security vulnerabilities found in image: |
859fdd5 to
6c1a657
Compare
SkArchon
commented
Jun 17, 2025
SkArchon
commented
Jun 17, 2025
SkArchon
commented
Jun 17, 2025
endigma
reviewed
Jun 18, 2025
Contributor
Author
|
@coderabbitai resolve |
Contributor
✅ Actions performedComments resolved. |
This was referenced Jul 8, 2025
yuzoonc1
pushed a commit
to yuzoonc1/cosmo
that referenced
this pull request
Jul 9, 2025
Co-authored-by: Dustin Deus <deusdustin@gmail.com>
5 tasks
This was referenced Jul 17, 2025
Closed
This was referenced Jul 24, 2025
Merged
5 tasks
This was referenced Aug 26, 2025
5 tasks
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This will add circuit breakers to the router. Circuit breakers are off by default, including metrics that are off by default.
We group subgraphs not by the name/id, but instead the routing url, and we create a circuit breaker per every single unique routing url. We use the full url, this means that
would result in two circuit breakers, since we consider the entire url.
User's can however force subgraph1 and subgraph2 to use two separate circuit breakers by specifying circuit breaker configurations at the per subgraph level.
Example configuration
Global config only
Subgraph disable for subgraph 5
Subgraph overrides
Even when the routing url is the same, this will result in separate circuit breakers being created
Options Included
This PR includes a configurable circuit breaker with the following configurations
In addition to this the PR introduces the following metrics
Docs PR: https://github.com/wundergraph/cosmo-docs/pull/104/files
Checklist
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Tests
Documentation