feat: edfs refactor kafka and nats with a datasource per field#1848
Merged
feat: edfs refactor kafka and nats with a datasource per field#1848
Conversation
…and-nats-as-datasource-in-router # Conflicts: # router/core/plan_generator.go
…ka, streamline provider initialization
…-datasource-in-router
…-datasource-in-router
…and planner files, enhance NATS subject validation
…actor-kafka-and-nats-as-datasource-in-router
…-datasource-in-router
…ment - Added InstanceData struct to encapsulate hostName and listenAddress. - Updated ExecutorConfigurationBuilder and ExecutorBuildOptions to include InstanceData. - Modified Loader and DefaultFactoryResolver to utilize InstanceData for better clarity and maintainability. - Refactored graphServer to initialize with InstanceData, enhancing the overall structure of the configuration.
…-datasource-in-router
…-datasource-in-router
…er to add a PubSubDataSource
…nd change event type to subscribe
devsergiy
reviewed
Jun 4, 2025
…actor-filtered-datasources
…actor-kafka-and-nats-as-datasource-in-router
…-in-router' into ale/eng-6482-edfs-refactor-filtered-datasources
…ubSubDataSourceFactory
devsergiy
reviewed
Jun 6, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Today changing or adding an EDFS provider requires changes to cosmo and the engine, making it harder than it should.
The main point of this PR is to make it easier to add future EDFS providers.
So I moved all the pubsub code from the engine to the pubsub package in the router and refactored it to make more sense with the new structure.
There is a README that will help implementing new EDFS providers (manually or using AI).
Important points
Design
Execution flow
Checklist