feat: expose type data and record subgraphs for enums

composition/src/federation/federation-factory.ts

@@ -566,6 +566,7 @@ export class FederationFactory {
     }
     existingData.appearances += 1;
     setLongestDescription(existingData, incomingData);
+    addIterableValuesToSet(incomingData.subgraphNames, existingData.subgraphNames);
   }
 
   // To facilitate the splitting of tag paths, field arguments do not use the renamedPath property for tagNamesByPath
@@ -1043,6 +1044,7 @@ export class FederationFactory {
     switch (existingData.kind) {
       case Kind.ENUM_TYPE_DEFINITION:
         existingData.appearances += 1;
+        addIterableValuesToSet((incomingData as EnumDefinitionData).subgraphNames, existingData.subgraphNames);
         for (const data of (incomingData as EnumDefinitionData).enumValueDataByValueName.values()) {
           this.upsertEnumValueData(existingData.enumValueDataByValueName, data, isParentInaccessible);
         }
@@ -2388,6 +2390,7 @@ export class FederationFactory {
         federatedGraphAST: newRouterAST,
         federatedGraphSchema: buildASTSchema(newRouterAST, { assumeValid: true, assumeValidSDL: true }),
         federatedGraphClientSchema: newClientSchema,
+        parentDefinitionDataByTypeName: this.parentDefinitionDataByTypeName,
         ...this.getClientSchemaObjectBoolean(),
       },
       warnings: this.warnings,
@@ -2671,6 +2674,7 @@ export class FederationFactory {
         federatedGraphAST: newRouterAST,
         federatedGraphSchema: buildASTSchema(newRouterAST, { assumeValid: true, assumeValidSDL: true }),
         federatedGraphClientSchema: newClientSchema,
+        parentDefinitionDataByTypeName: this.parentDefinitionDataByTypeName,
         ...this.getClientSchemaObjectBoolean(),
       },
       warnings: this.warnings,

composition/src/federation/utils.ts

@@ -45,6 +45,7 @@ export type FederationResult = {
   federatedGraphAST: DocumentNode;
   federatedGraphClientSchema: GraphQLSchema;
   federatedGraphSchema: GraphQLSchema;
+  parentDefinitionDataByTypeName: Map<string, ParentDefinitionData>;
   subgraphConfigBySubgraphName: Map<string, SubgraphConfig>;
   shouldIncludeClientSchema?: boolean;
 };

composition/src/normalization/normalization-factory.ts

@@ -848,6 +848,7 @@ export class NormalizationFactory {
         return;
       }
       this.setParentDataExtensionType(parentData, extensionType);
+      parentData.subgraphNames.add(this.subgraphName);
       parentData.description ||= formatDescription('description' in node ? node.description : undefined);
       return;
     }
@@ -860,6 +861,7 @@ export class NormalizationFactory {
       name: typeName,
       node: getMutableEnumNode(node.name),
       persistedDirectivesData: newPersistedDirectivesData(),
+      subgraphNames: new Set([this.subgraphName]),
       description: formatDescription('description' in node ? node.description : undefined),
     });
   }

composition/src/normalization/walkers.ts

@@ -313,6 +313,7 @@ export function upsertParentsAndChildren(nf: NormalizationFactory, document: Doc
           nf.directiveDefinitionByDirectiveName,
           nf.handledRepeatedDirectivesByHostPath,
           nf.originalParentTypeName,
+          nf.subgraphName,
         );
       },
       leave() {

composition/src/schema-building/type-definition-data.ts

@@ -35,6 +35,7 @@ export type EnumDefinitionData = {
   name: string;
   node: MutableEnumNode;
   persistedDirectivesData: PersistedDirectivesData;
+  subgraphNames: Set<string>;
   description?: StringValueNode;
 };
 
@@ -45,6 +46,7 @@ export type EnumValueData = {
   node: MutableEnumValueNode;
   parentTypeName: string;
   persistedDirectivesData: PersistedDirectivesData;
+  subgraphNames: Set<string>;
   description?: StringValueNode;
 };
 

composition/src/schema-building/utils.ts

@@ -439,6 +439,7 @@ export function addEnumValueDataByNode(
   directiveDefinitionByDirectiveName: Map<string, DirectiveDefinitionNode>,
   handledRepeatedDirectivesByHostPath: Map<string, Set<string>>,
   parentTypeName: string,
+  subgraphName: string,
 ) {
   const name = node.name.value;
   enumValueDataByValueName.set(name, {
@@ -455,6 +456,7 @@ export function addEnumValueDataByNode(
     node: getMutableEnumValueNode(node),
     parentTypeName,
     persistedDirectivesData: newPersistedDirectivesData(),
+    subgraphNames: new Set([subgraphName]),
     description: formatDescription(node.description),
   });
 }

composition/tests/enums.test.ts

@@ -1,6 +1,7 @@
 import {
   duplicateEnumValueDefinitionError,
   ENUM,
+  EnumDefinitionData,
   federateSubgraphs,
   incompatibleSharedEnumError,
   noBaseDefinitionForExtensionError,
@@ -521,6 +522,18 @@ describe('Enum tests', () => {
         ),
       );
     });
+
+    test('that an Enum has subgraphs data', () => {
+      const { errors, federationResult } = federateSubgraphs([subgraphA, subgraphC]);
+      expect(errors).toBeUndefined();
+
+      const enumDef = federationResult?.parentDefinitionDataByTypeName.get('Instruction') as EnumDefinitionData;
+
+      expect(enumDef.subgraphNames.size).toBe(2);
+      expect(enumDef.enumValueDataByValueName.get('FIGHT')?.subgraphNames.size).toBe(2);
+      expect(enumDef.enumValueDataByValueName.get('POKEMON')?.subgraphNames.size).toBe(2);
+      expect(enumDef.enumValueDataByValueName.get('ITEM')?.subgraphNames.size).toBe(1);
+    });
   });
 });