-
Notifications
You must be signed in to change notification settings - Fork 142
fix(router): ensure persisted operation hits both with and without op name #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Router image scan passed✅ No security vulnerabilities found in image:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5e55e33
to
dad502e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation and Context
We previously included operation name in the persisted operation cache key. As a result, though, when a persisted operation was stored with a operation name, and someone called it without that operation name, it wouldn't return a cache hit, despite the fact that it was a match. This PR removes the operation name from the cache key, given that it is irrelevant to how specialized we want it to be
Checklist