Skip to content

fix(router): ensure persisted operation hits both with and without op name #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 5, 2025

Conversation

df-wg
Copy link
Contributor

@df-wg df-wg commented Dec 23, 2024

Motivation and Context

We previously included operation name in the persisted operation cache key. As a result, though, when a persisted operation was stored with a operation name, and someone called it without that operation name, it wouldn't return a cache hit, despite the fact that it was a match. This PR removes the operation name from the cache key, given that it is irrelevant to how specialized we want it to be

Checklist

Copy link

github-actions bot commented Dec 23, 2024

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-86f063867e528024b1f1955446990b2bae24ad10

Copy link
Member

@jensneuse jensneuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@df-wg df-wg force-pushed the dave/eng-6143-fix-persisted-operation-cache-miss branch from 5e55e33 to dad502e Compare December 23, 2024 17:28
@df-wg df-wg requested review from jensneuse and StarpTech December 23, 2024 17:29
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@df-wg df-wg merged commit 91ee80f into main Jan 5, 2025
13 checks passed
@df-wg df-wg deleted the dave/eng-6143-fix-persisted-operation-cache-miss branch January 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants