chore: remove go workspace, handle them personal to each developer#1357
Merged
chore: remove go workspace, handle them personal to each developer#1357
Conversation
df-wg
approved these changes
Nov 10, 2024
Contributor
df-wg
left a comment
There was a problem hiding this comment.
In general, lgtm. One additional change I'd like to see would be explicit recommendations in Contributing.md, perhaps, about how it's best to configure a personal workspace to make things smooth, if there is any difference from our current workflow
thisisnithin
approved these changes
Nov 10, 2024
Contributor
Author
|
@df-wg addressed, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Introduction
Although go workspace has been built to simplify managing multiple modules in a single codebase, we run into couple of very serious issues that we were not able to solve deterministically.
One example: We upgraded a dependency that is not used in any other Go module. This upgrade had the effect that another module dependency was upgraded. Due to this behaviour it was impossible to understand the dependency tree because the change was not reflected in the mod or sum file of any module. Luckily, our CI has catched this before it become a serious issue.
Conclusion
We used workspaces the wrong way. Meanwhile, community has built an opinion around the usage of Go workspaces. Go workspaces should be handled as personal to each developer and therefore not be committed.
This makes sense, if you see them as a more manageable approach to replace directives.
More information https://earthly.dev/blog/go-workspaces/
Checklist