Conversation
JivusAyrus
approved these changes
Aug 28, 2023
jensneuse
added a commit
that referenced
this pull request
Apr 24, 2026
- #13: start the race-test deadline after workers are scheduled so -race + parallel tests don't execute near-zero iterations. Applied in all three race tests (TestArticleStoreNoRace, TestListingStoreNoRace, TestResolverPathNoRace) - #14: nil-guard location.Address in the cachegraph Venue query resolver; returns "location.address is required" instead of panicking on nil deref - #15: parameterize `make demo` startup wait via DEMO_STARTUP_ATTEMPTS (default 60) and DEMO_STARTUP_SLEEP (default 0.5). Previous hard-coded 20 × 0.5s was too short on cold checkouts Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR instrument the Router with OpenTelemetry Metrics. All metrics are exposed through the
PrometheusExporteron porthttp://127.0.0.1:8088/metrics(configurable) and sent to the otelcollector metrics endpoint.The PR introduces built-in support for Prometheus. Data is exposed at http://127.0.0.1:8088/metrics. We export the default Go and Process metrics. In addition, we export (R.E.D) metrics related to incoming GraphQL traffic:
All metrics are tracked along the following dimensions:
This enables you to answer the following questions:
During this work, I found dealing with net/http handlers and custom gin middleware very cumbersome to manage. I used the time to migrate to chin which is 100% compatible with the std library. This is also an important step towards custom middleware support in the router. I refactored the GraphQL handlers for easier testing as well.
TODO