feat: return error if federated graph has no query root type#12
Merged
Aenimus merged 1 commit intodavid/eng-3753-add-argument-configurationfrom Aug 25, 2023
Conversation
ysmolski
deleted the
david/eng-3808-return-error-if-no-query-root-type
branch
jensneuse
added a commit
that referenced
this pull request
Apr 24, 2026
…review #7, #12) - #7: rename benchmark mode cache_disabled -> entity_cache_disabled so the label reflects what is actually disabled (X-WG-Disable-Entity-Cache only; there is no router header for query-cache). Updated in lib.ts, lib.test.ts, and scenarios/cache-demo.json. - #12: document cross-subgraph TTL divergence in docs/entity-caching/directives.md. The composed router config keeps per-datasource entityCacheConfigurations entries (demo/cachegraph Article maxAge: 120, demo/cachegraph-ext Article maxAge: 90 are preserved separately). Coderabbit's claim that composition collapses them was incorrect; the section now explicitly states the real behavior and recommends aligning maxAge values for shared entity types. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context