Skip to content

feat: show diff in schema checks #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaniAkash wants to merge 5 commits into from
Closed

feat: show diff in schema checks #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01c8eb4
feat: show diff in schema checks
DaniAkash Aug 25, 2023
7098c14
fix: make schemaVersionId optional
DaniAkash Aug 25, 2023
dc128a6
fix: test cases
DaniAkash Aug 29, 2023
8ebd2f4
Merge branch 'main' into dani/eng-3681-show-diff-in-schema-check-if-w…
DaniAkash Aug 29, 2023
c0f3bb7
Merge branch 'main' into dani/eng-3681-show-diff-in-schema-check-if-w…
DaniAkash Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions connect/src/wg/cosmo/platform/v1/platform_pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,6 +1910,11 @@ export class SchemaCheck extends Message<SchemaCheck> {
*/
proposedSubgraphSchemaSDL?: string;

/**
* @generated from field: string originalSchemaSDL = 8;
*/
originalSchemaSDL = "";

constructor(data?: PartialMessage<SchemaCheck>) {
super();
proto3.util.initPartial(data, this);
Expand All @@ -1925,6 +1930,7 @@ export class SchemaCheck extends Message<SchemaCheck> {
{ no: 5, name: "isComposable", kind: "scalar", T: 8 /* ScalarType.BOOL */ },
{ no: 6, name: "isBreaking", kind: "scalar", T: 8 /* ScalarType.BOOL */ },
{ no: 7, name: "proposedSubgraphSchemaSDL", kind: "scalar", T: 9 /* ScalarType.STRING */, opt: true },
{ no: 8, name: "originalSchemaSDL", kind: "scalar", T: 9 /* ScalarType.STRING */ },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): SchemaCheck {
Expand Down
1 change: 1 addition & 0 deletions controlplane/drizzle/meta/_journal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"version":"5","dialect":"pg","entries":[]}
6 changes: 6 additions & 0 deletions controlplane/migrations/0039_old_wrecking_crew.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
ALTER TABLE "schema_checks" ADD COLUMN "schema_version_id" uuid NOT NULL;--> statement-breakpoint
Copy link
Copy Markdown
Member

@JivusAyrus JivusAyrus Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration to populate the schema_version_id to the already existing schema checks?

DO $$ BEGIN
ALTER TABLE "schema_checks" ADD CONSTRAINT "schema_checks_schema_version_id_schema_versions_id_fk" FOREIGN KEY ("schema_version_id") REFERENCES "schema_versions"("id") ON DELETE no action ON UPDATE no action;
EXCEPTION
WHEN duplicate_object THEN null;
END $$;
1 change: 1 addition & 0 deletions controlplane/migrations/0040_charming_sunfire.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE "schema_checks" ALTER COLUMN "schema_version_id" DROP NOT NULL;
Loading